Optimization of REXML::Parsers::SAX2Parser#get_procs, #get_listeners #303
+4
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Sep 21, 2025
naitoh
force-pushed
the
fix_get_procs_get_listeners_performance_sax
branch
from
96e1fd5 to
ea63857
Compare
## Benchmark
```
$ benchmark-driver benchmark/sax.yaml
before after before(YJIT) after(YJIT)
sax 2.309k 2.317k 2.760k 2.879k i/s - 100.000 times in 0.043300s 0.043155s 0.036238s 0.034738s
Comparison:
sax
after(YJIT): 2878.7 i/s
before(YJIT): 2759.5 i/s - 1.04x slower
after: 2317.2 i/s - 1.24x slower
before: 2309.5 i/s - 1.25x slower
```
- YJIT=ON : 1.04x faster
- YJIT=OFF : 1.00x faster
naitoh
force-pushed
the
fix_get_procs_get_listeners_performance_sax
branch
from
ea63857 to
27e5a09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark