Skip to content

Fixed an issue when executing REXML::Parsers::SAX2Parser#parse without specifying #listen #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Sep 21, 2025
+7 −1
Merged

Fixed an issue when executing REXML::Parsers::SAX2Parser#parse without specifying #listen #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rexml/parsers/sax2parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def parse
ob.end_element( uri, local, event[1] )
} if listeners

namespace_mapping = @namespace_stack.pop
namespace_mapping = @namespace_stack.pop if procs or listeners
# find the observers for namespaces
procs = get_procs( :end_prefix_mapping, event[1] )
listeners = get_listeners( :end_prefix_mapping, event[1] )
Expand Down
6 changes: 6 additions & 0 deletions test/test_sax.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ module REXMLTests
class SAX2Tester < Test::Unit::TestCase
include Helper::Fixture
include REXML

def test_without_listien
p = Parsers::SAX2Parser.new "<a><a></a></a>"
p.parse
end

def test_characters
d = Document.new( "<A>@blah@</A>" )
txt = d.root.text
Expand Down
Loading