Optimization of REXML::Parsers::SAX2Parser#get_namespace #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Sep 16, 2025
naitoh
force-pushed
the
fix_get_namespace_performance_sax
branch
from
5defaea to
e41b6b0
Compare
kou
reviewed
Sep 17, 2025
## Benchmark
```
before after before(YJIT) after(YJIT)
sax 1.415k 2.297k 1.755k 2.958k i/s - 100.000 times in 0.070687s 0.043539s 0.056966s 0.033810s
Comparison:
sax
after(YJIT): 2957.7 i/s
after: 2296.8 i/s - 1.29x slower
before(YJIT): 1755.4 i/s - 1.68x slower
before: 1414.7 i/s - 2.09x slower
```
- YJIT=ON : 1.68x faster
- YJIT=OFF : 1.62x faster
naitoh
force-pushed
the
fix_get_namespace_performance_sax
branch
from
e41b6b0 to
3369f96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark