Skip to content

Fix SEGV on RBS::Location#[] without Symbol arg #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ksss wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Open

Fix SEGV on RBS::Location#[] without Symbol arg #2811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ext/rbs_extension/legacy_location.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,9 @@ static VALUE rbs_new_location_from_loc_range(VALUE buffer, rbs_loc_range rg) {
}

static rbs_constant_id_t rbs_constant_pool_find_ruby_symbol(VALUE symbol) {
if (!RB_TYPE_P(symbol, T_SYMBOL)) {
rb_raise(rb_eTypeError, "wrong argument type %" PRIsVALUE " (must be a Symbol)", rb_obj_class(symbol));
}
VALUE name = rb_sym2str(symbol);

return rbs_constant_pool_find(RBS_GLOBAL_CONSTANT_POOL, (const uint8_t *) RSTRING_PTR(name), RSTRING_LEN(name));
Expand Down
5 changes: 5 additions & 0 deletions test/rbs/location_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ def test_location_aref
assert_equal "abc", loc[:alpha].source
end

def test_location_aref_invalid_argument
loc = Location.new(buffer, 0, 8)
assert_raise(TypeError) { loc["string"] }
end

def test_location_start_pos
loc = Location.new(buffer, 0, 8)
assert_equal 0, loc.start_pos
Expand Down
Loading