use optional record keys for several API options#1900
Open
HoneyryderChuck wants to merge 1 commit intoruby:masterfrom
Open
use optional record keys for several API options#1900HoneyryderChuck wants to merge 1 commit intoruby:masterfrom
HoneyryderChuck wants to merge 1 commit intoruby:masterfrom
Conversation
eaf2497 to
7d4f483
Compare
bd4c4af to
ca9e03a
Compare
ca9e03a to
fca4c65
Compare
Contributor
Author
|
@soutaro it's ready for review 🙏 |
Member
|
Thank you for your work! 🎉 I'm totally good for using optional records for return values. However, using the records instead of opts = {}
# Set up opts
CGI.new(opts) # Type error because it's a Hash, not a recordWhat do you think about this? |
Contributor
Author
|
I'll run some tests locally to see if this impacts rbs runtime type check significantly. Nevertheless, I think there's great value in being precise on the options you accept in a hash as a function argument, particularly in examples such as ssl context, or URI build functions. That's definitely something steep could be a bit smarter about 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.