Fix task description truncated when space follows period#734
Open
mitre88 wants to merge 1 commit intoruby:masterfrom
Open
Fix task description truncated when space follows period#734mitre88 wants to merge 1 commit intoruby:masterfrom
mitre88 wants to merge 1 commit intoruby:masterfrom
Conversation
The first_sentence method was incorrectly splitting on period followed by any whitespace, which caused descriptions like 'foo. bar' to be truncated to just 'foo'. For example: - 'foo. bar' was truncated to 'foo' (bug) - 'foo.bar' remained 'foo.bar' (correct) - 'This is a task. It has more.' became 'This is a task' (correct) The new regex uses a positive lookbehind to match sentence terminators (. ! ?) followed by one or more spaces, which correctly handles: - Multiple sentences separated by spaces - Decimal points (e.g. doesn't end a sentence) - Periods in abbreviations - Cases where a period is followed by a newline instead of space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first_sentence method was incorrectly splitting on period followed by any whitespace, which caused descriptions like 'foo. bar' to be truncated to just 'foo'.
For example:
The new regex uses a positive lookbehind to match sentence terminators (. ! ?) followed by one or more spaces, which correctly handles: