Check using Prism nodes if a command call has any arguments in Ripper translator #3867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Thinking more about it, it seems far better to just check |
eregon
force-pushed
the
check-if-array-before-calling-any
branch
from
5406f51 to
413616f
Compare
eregon
changed the title
Member
Author
|
Done, this feels like a proper fix. |
… translator * We don't know what `on_*` events might return so we cannot assume it's an Array. * See ruby#3838 (comment)
eregon
force-pushed
the
check-if-array-before-calling-any
branch
from
413616f to
bed4271
Compare
Member
Author
|
Added a test as well and confirmed it fails before the fix (with 132 failures). |
Member
Author
|
@Earlopain could you review this? |
We should touch these as little as possible and just pass them along
Earlopain
approved these changes
Jan 21, 2026
Collaborator
Earlopain
left a comment
Earlopain
left a comment
There was a problem hiding this comment.
I tweaked it slightly, see added commit. I'm positively surprised it's only needed in so few places. Feel free to merge if the addition looks good to you.
BTW, this also fixes the very simple case of "foo bar". It's now correctly reported on_command instead of on_fcall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on_*events might return so we cannot assume it's an Array.