Correctly expose ripper state #3841
Merged
+88
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
ripper-translator-state
branch
from
be41417 to
7302111
Compare
kddnewton
approved these changes
Jan 9, 2026
Collaborator
|
Looks like some valid test failures |
Collaborator
Author
|
Oh, this is trying to use the real ripper state again. I will namespace this properly in a bit. |
It is for example used by `irb`, `rdoc`, `syntax_suggest`
Earlopain
force-pushed
the
ripper-translator-state
branch
from
7302111 to
255aeb2
Compare
kddnewton
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is for example used by
irb,rdoc,syntax_suggest. It's undocumented but they need it to work. I already wrote this code, this mostly moves things to the right place.I want to work on making irb not crash when using the ripper shim.