Add pattern matching support to Net::HTTPExceptions#243
Open
baweaver wants to merge 2 commits intoruby:masterfrom
Open
Add pattern matching support to Net::HTTPExceptions#243baweaver wants to merge 2 commits intoruby:masterfrom
baweaver wants to merge 2 commits intoruby:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
deconstruct_keysto theNet::HTTPExceptionsmodule, enabling pattern matching on HTTP exception classes for cleaner error handling.Usage
Implementation
PATTERN_MATCHING_KEYSconstant toHTTPExceptionsmodule with keys: message, responsedeconstruct_keysfollowing Ruby pattern matching best practicesHTTPError,HTTPRetriableError,HTTPClientException,HTTPFatalErrorinstance_evalwithSyntaxErrorrescue for Ruby 2.6 compatibility