Skip instrumentation in run_validators when no validators present#2667
Merged
Skip instrumentation in run_validators when no validators present#2667
Conversation
Danger ReportNo issues found. |
Avoids unnecessary ParamScopeTracker setup and AS::Notifications instrumentation for endpoints that have no validators. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ericproulx
force-pushed
the
skip_instrumentation_no_validators
branch
from
b4b7f59 to
586641f
Compare
Contributor
Author
|
@dblock I'm gonna cut a version this week. |
dblock
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_validatorswhensaved_validationsis empty, skippingParamScopeTracker.trackandActiveSupport::Notificationsinstrumentation entirely.Motivation
Every request paid the overhead of the
endpoint_run_validators.grapenotification and tracker setup even when the endpoint declared no params at all. With this change those are only invoked when there is actual work to do.Breaking change
endpoint_run_validators.grapeis no longer fired for endpoints with no validators. Documented inUPGRADING.mdunder>= 3.2.