Skip to content

Run tests with warnings enabled#1425

Open
bf4 wants to merge 1 commit intoruby-grape:masterfrom
bf4:run_test_with_warnings
Open

Run tests with warnings enabled#1425
bf4 wants to merge 1 commit intoruby-grape:masterfrom
bf4:run_test_with_warnings

Conversation

@bf4
Copy link
Copy Markdown

@bf4 bf4 commented Jun 14, 2016

Should help clean up warnings in gems or apps that use Grape ;)

refs:

Should help clean up warnings in gems or apps that use Grape ;)

refs:
- http://mislav.net/2011/06/ruby-verbose-mode/
@dblock
Copy link
Copy Markdown
Member

dblock commented Jun 14, 2016

I looked at the output in https://travis-ci.org/ruby-grape/grape/jobs/137408689 and there're some juicy ones that seem like they should be fixed. Would you like to address them as part of this PR?

@bf4
Copy link
Copy Markdown
Author

bf4 commented Jun 14, 2016

Depends on how soon you'd like this merged... :) we run AMS tests w warnings on and grape is main offender, but otherwise I'm juggling a bunch of stuff right now (as are we all)

B mobile phone

On Jun 14, 2016, at 7:00 AM, Daniel Doubrovkine (dB.) @dblockdotorg notifications@github.com wrote:

I looked at the output in https://travis-ci.org/ruby-grape/grape/jobs/137408689 and there're some juicy ones that seem like they should be fixed. Would you like to address them as part of this PR?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@dblock
Copy link
Copy Markdown
Member

dblock commented Jun 14, 2016

I'll wait or will pick this up. I agree that this is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants