Modernize gemspec: add metadata, use Dir glob, drop defaults#401
Merged
Conversation
Replace git ls-files shell-out with Dir glob to avoid dependency on git at build time. Add RubyGems metadata (homepage, bug tracker, changelog, docs, source) and require MFA for gem pushes. Remove redundant s.platform since Gem::Platform::RUBY is the default.
Danger ReportNo issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git ls-filesshell-out withDir['lib/**/*.rb', ...]to avoiddependency on git at build time and prevent accidental inclusion of
non-Ruby files or directories
and require MFA for gem pushes via
rubygems_mfa_requireds.platform = Gem::Platform::RUBY(it is the default)