Add N plus one operation solution section to README#392
Merged
dblock merged 1 commit intoruby-grape:masterfrom Oct 14, 2025
Merged
Add N plus one operation solution section to README#392dblock merged 1 commit intoruby-grape:masterfrom
dblock merged 1 commit intoruby-grape:masterfrom
Conversation
dblock
requested changes
Oct 13, 2025
Member
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
Nice! Let's put this in the right section of the README?
README.md
Outdated
|
|
||
| $ gem install grape-entity | ||
|
|
||
| ## N plus one operation solution |
Member
There was a problem hiding this comment.
Let's just call this Preloading Associations and move it up above "Caveats"?
Suggested change
| ## N plus one operation solution | |
| ### Preloading Associations |
README.md
Outdated
|
|
||
| ## N plus one operation solution | ||
|
|
||
| [Grape::Entity::Preloader](https://github.com/OuYangJinTing/grape-entity-preloader) allows preload associations and callbacks for avoiding N+1 operations in Grape::Entity. |
Member
There was a problem hiding this comment.
Suggested change
| [Grape::Entity::Preloader](https://github.com/OuYangJinTing/grape-entity-preloader) allows preload associations and callbacks for avoiding N+1 operations in Grape::Entity. | |
| Use [Grape::Entity::Preloader](https://github.com/OuYangJinTing/grape-entity-preloader) to preload associations and callbacks and avoid N+1 operations. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
OuYangJinTing
force-pushed
the
n-plus-one-operation-solution
branch
from
d5d999f to
9120449
Compare
Contributor
Author
|
@dblock Thank. I have readjusted the copy. |
dblock
approved these changes
Oct 14, 2025
Member
|
Thanks, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a new section in the README to document for introduction of Grape::Entity::Preloader