Skip to content

Conversation

@numbata
Copy link
Collaborator

@numbata numbata commented Dec 18, 2025

This pull request makes several improvements to the Danger integration by simplifying the Dangerfile logic, updating workflow references for better maintainability, and clarifying the documentation. The most significant changes are grouped below.

Dangerfile and workflow logic improvements:

  • Simplified the at_exit hook in the Dangerfile to directly reference the current Dangerfile instance instead of searching through all objects, making the export logic more robust and efficient.
  • Updated the error check in .github/workflows/danger-comment.yml to use the hasItems utility for consistency and reliability.

Documentation and workflow reference updates:

  • Changed all workflow references in the README.md from ruby-grape/ruby-grape-danger to ruby-grape/danger, reflecting the new reusable workflow location for easier updates and consistency across projects.
  • Removed the "Benefits of Reusable Workflows" section from the README.md to streamline and clarify the documentation.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Danger Report

ℹ️ Messages

  • We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request improves the Danger integration by updating dependency versions, simplifying the Dangerfile logic, standardizing workflow references, and streamlining documentation. The key changes include updating the danger-changelog dependency to version 0.8, refactoring the at_exit hook to capture the Dangerfile instance directly instead of using ObjectSpace, updating all workflow references to point to ruby-grape/danger instead of ruby-grape/ruby-grape-danger, and removing redundant documentation sections.

Key Changes

  • Updated danger-changelog dependency from ~> 0.7 to ~> 0.8
  • Refactored Dangerfile's at_exit hook to capture the Dangerfile instance upfront rather than searching through ObjectSpace
  • Standardized workflow references from ruby-grape/ruby-grape-danger to ruby-grape/danger throughout README

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
ruby-grape-danger.gemspec Bumps danger-changelog dependency to version 0.8
README.md Updates workflow references to use ruby-grape/danger path and removes "Benefits of Reusable Workflows" section
Dangerfile Simplifies at_exit hook by directly capturing the Dangerfile instance instead of using ObjectSpace iteration
.github/workflows/danger-comment.yml Updates error checking to use the hasItems utility function for consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dblock dblock merged commit 90a8da4 into ruby-grape:master Dec 18, 2025
1 check passed
@numbata
Copy link
Collaborator Author

numbata commented Dec 18, 2025

I was so close to hitting the merge button. 😃

@dblock
Copy link
Member

dblock commented Dec 18, 2025

I was so close to hitting the merge button. 😃

I do code reviews! :)

@numbata
Copy link
Collaborator Author

numbata commented Dec 18, 2025

I'll do release then. 0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants