-
Notifications
You must be signed in to change notification settings - Fork 9
Report workflow postreview fixes #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report workflow postreview fixes #16
Conversation
Danger Reportℹ️ Messages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request improves the Danger integration by updating dependency versions, simplifying the Dangerfile logic, standardizing workflow references, and streamlining documentation. The key changes include updating the danger-changelog dependency to version 0.8, refactoring the at_exit hook to capture the Dangerfile instance directly instead of using ObjectSpace, updating all workflow references to point to ruby-grape/danger instead of ruby-grape/ruby-grape-danger, and removing redundant documentation sections.
Key Changes
- Updated
danger-changelogdependency from~> 0.7to~> 0.8 - Refactored Dangerfile's at_exit hook to capture the Dangerfile instance upfront rather than searching through ObjectSpace
- Standardized workflow references from
ruby-grape/ruby-grape-dangertoruby-grape/dangerthroughout README
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ruby-grape-danger.gemspec | Bumps danger-changelog dependency to version 0.8 |
| README.md | Updates workflow references to use ruby-grape/danger path and removes "Benefits of Reusable Workflows" section |
| Dangerfile | Simplifies at_exit hook by directly capturing the Dangerfile instance instead of using ObjectSpace iteration |
| .github/workflows/danger-comment.yml | Updates error checking to use the hasItems utility function for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I was so close to hitting the merge button. 😃 |
I do code reviews! :) |
|
I'll do release then. 0.3.0 |
This pull request makes several improvements to the Danger integration by simplifying the Dangerfile logic, updating workflow references for better maintainability, and clarifying the documentation. The most significant changes are grouped below.
Dangerfile and workflow logic improvements:
at_exithook in theDangerfileto directly reference the current Dangerfile instance instead of searching through all objects, making the export logic more robust and efficient..github/workflows/danger-comment.ymlto use thehasItemsutility for consistency and reliability.Documentation and workflow reference updates:
README.mdfromruby-grape/ruby-grape-dangertoruby-grape/danger, reflecting the new reusable workflow location for easier updates and consistency across projects.README.mdto streamline and clarify the documentation.