Move topology recovery to Bunny::Session #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a direct copy of how topology is tracked in the Java client since 2014-2015. See #704 for background.
when server-named queues get a new name after their recovery, all queue bindings and consumers recorded must be updated.
1. Correct TopologyRegistry 2. Only perform topology recovery after the connection and its channels are recovered 3. More logging in recovery tests, less in Bunny::Session when connection recovery is enabled
This was referenced Apr 21, 2025
michaelklishin
added a commit
that referenced
this pull request
Dec 31, 2025
Move topology recovery to Bunny::Session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more or less direct port of how the Java client implements topology recovery, sans a few features that can be introduced at a later point:
So the scope of this change is strictly #704 and one additional layer of testing (that of
Bunny::TopologyRegistry).Closes #704.