Feat/rspec test runner by cosgroveb · Pull Request #534 · rtk-ai/rtk

cosgroveb · 2026-03-12T12:02:02Z

Summary

Add rtk rspec command. Parses rspec JSON output, shows failures and pending tests only (87% reduction for me)
Falls back to regex when JSON isn't available, passthrough when neither works
Handles rspec, bundle exec rspec, and any flags
Hook rewrite rules included

Test plan

JSON parsing, regex fallback, passthrough, edge cases
Token savings at least 87% verified against real rspec output
Smoke test in test-all.sh (skips when rspec not installed)
cargo fmt --all --check passes
cargo clippy --all-targets clean
All existing tests still pass

Signed-off-by: Brian Cosgrove <cosgroveb@gmail.com>

Adds conditional rspec test to test-all.sh (skips when rspec not installed). Fixes 'skip' to 'skip_test' for Graphite test. Signed-off-by: Brian Cosgrove <cosgroveb@gmail.com>

Unifies 5 competing PRs (rtk-ai#198, rtk-ai#292, rtk-ai#379, rtk-ai#534, rtk-ai#643) into a single coherent implementation. New commands: - rtk rspec: JSON parsing with text fallback (60%+ savings) - rtk rubocop: JSON parsing, group by cop/severity (60%+ savings) - rtk rake test: Minitest state machine parser (85-90% savings) - rtk bundle install: TOML filter, strip Using lines (90%+ savings) Shared infrastructure: ruby_exec(), fallback_tail(), exit_code_from_output(), count_tokens() in utils.rs. Discover/rewrite rules for rspec, rubocop, rake, rails, bundle including bundle exec and bin/ variants. 56 new unit tests + 4 inline TOML tests. All 1035 tests passing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Unifies 5 competing PRs (rtk-ai#198, rtk-ai#292, rtk-ai#379, rtk-ai#534, rtk-ai#643) into a single coherent implementation. New commands: - rtk rspec: JSON parsing with text fallback (60%+ savings) - rtk rubocop: JSON parsing, group by cop/severity (60%+ savings) - rtk rake test: Minitest state machine parser (85-90% savings) - rtk bundle install: TOML filter, strip Using lines (90%+ savings) Shared infrastructure: ruby_exec(), fallback_tail(), exit_code_from_output(), count_tokens() in utils.rs. Discover/rewrite rules for rspec, rubocop, rake, rails, bundle including bundle exec and bin/ variants. E2E smoke tests (scripts/test-ruby.sh) covering all 4 commands. 56 new unit tests + 4 inline TOML tests. All 1035 tests passing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Navid EMAD <navid.emad@yespark.fr>

navidemad · 2026-03-19T13:20:39Z

Hey @cosgroveb — I created a unified PR at #724 that merges all 5 competing Ruby implementations (#198, #292, #379, #534, #643).

Your improved format flag detection is incorporated — specifically the handling of -fj, -fjson, -fdocumentation, and --format=... patterns that the other PRs missed, along with your 4 dedicated tests.

Thanks for catching those edge cases!

cosgroveb · 2026-03-19T13:53:10Z

Perfect

cosgroveb · 2026-03-19T13:57:53Z

Closed in favor of #724

…724) * feat(ruby): add Ruby on Rails support (rspec, rubocop, rake, bundle) Unifies 5 competing PRs (#198, #292, #379, #534, #643) into a single coherent implementation. New commands: - rtk rspec: JSON parsing with text fallback (60%+ savings) - rtk rubocop: JSON parsing, group by cop/severity (60%+ savings) - rtk rake test: Minitest state machine parser (85-90% savings) - rtk bundle install: TOML filter, strip Using lines (90%+ savings) Shared infrastructure: ruby_exec(), fallback_tail(), exit_code_from_output(), count_tokens() in utils.rs. Discover/rewrite rules for rspec, rubocop, rake, rails, bundle including bundle exec and bin/ variants. E2E smoke tests (scripts/test-ruby.sh) covering all 4 commands. 56 new unit tests + 4 inline TOML tests. All 1035 tests passing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Navid EMAD <navid.emad@yespark.fr> * fix(ruby): use TEST= env var for rake single-file test in smoke tests Rails' `rake test` ignores positional file args; use `TEST=path` syntax. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Navid EMAD <navid.emad@yespark.fr> * docs(ruby): add Ruby module architecture and update attribution Integrate ARCHITECTURE.md Ruby Module Architecture section and CLAUDE.md module table/fork-features from PR #643. Update PR description attribution. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Navid EMAD <navid.emad@yespark.fr> * chore: remove PULL_REQUEST_DESCRIPTION.md from repo PR description lives on GitHub, no need to track in the codebase. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Navid EMAD <navid.emad@yespark.fr> --------- Signed-off-by: Navid EMAD <navid.emad@yespark.fr> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…tk-ai#724) * feat(ruby): add Ruby on Rails support (rspec, rubocop, rake, bundle) Unifies 5 competing PRs (rtk-ai#198, rtk-ai#292, rtk-ai#379, rtk-ai#534, rtk-ai#643) into a single coherent implementation. New commands: - rtk rspec: JSON parsing with text fallback (60%+ savings) - rtk rubocop: JSON parsing, group by cop/severity (60%+ savings) - rtk rake test: Minitest state machine parser (85-90% savings) - rtk bundle install: TOML filter, strip Using lines (90%+ savings) Shared infrastructure: ruby_exec(), fallback_tail(), exit_code_from_output(), count_tokens() in utils.rs. Discover/rewrite rules for rspec, rubocop, rake, rails, bundle including bundle exec and bin/ variants. E2E smoke tests (scripts/test-ruby.sh) covering all 4 commands. 56 new unit tests + 4 inline TOML tests. All 1035 tests passing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Navid EMAD <navid.emad@yespark.fr> * fix(ruby): use TEST= env var for rake single-file test in smoke tests Rails' `rake test` ignores positional file args; use `TEST=path` syntax. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Navid EMAD <navid.emad@yespark.fr> * docs(ruby): add Ruby module architecture and update attribution Integrate ARCHITECTURE.md Ruby Module Architecture section and CLAUDE.md module table/fork-features from PR rtk-ai#643. Update PR description attribution. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Navid EMAD <navid.emad@yespark.fr> * chore: remove PULL_REQUEST_DESCRIPTION.md from repo PR description lives on GitHub, no need to track in the codebase. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Navid EMAD <navid.emad@yespark.fr> --------- Signed-off-by: Navid EMAD <navid.emad@yespark.fr> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

cosgroveb and others added 10 commits March 12, 2026 11:23

Scaffold rspec_cmd with JSON deserializer and Tier 1 parser

6d9c6a6

Signed-off-by: Brian Cosgrove <cosgroveb@gmail.com>

Add Tier 1 tests for failures, pending, edge cases

3e4f863

Signed-off-by: Brian Cosgrove <cosgroveb@gmail.com>

Implement Tier 2 regex fallback for progress format

588f596

Signed-off-by: Brian Cosgrove <cosgroveb@gmail.com>

Add Tier 3 passthrough and token savings tests

50de810

Signed-off-by: Brian Cosgrove <cosgroveb@gmail.com>

Implement run() with invocation auto-detect and --out flag injection

3728259

Signed-off-by: Brian Cosgrove <cosgroveb@gmail.com>

Wire up rspec command routing in main.rs

01f767f

Signed-off-by: Brian Cosgrove <cosgroveb@gmail.com>

Add rspec rewrite rules for hook integration

9ad13dd

Signed-off-by: Brian Cosgrove <cosgroveb@gmail.com>

Format rspec code

2768036

Signed-off-by: Brian Cosgrove <cosgroveb@gmail.com>

Add rspec command documentation

6fd93f6

Signed-off-by: Brian Cosgrove <cosgroveb@gmail.com>

Add rspec smoke test and fix Graphite test helper typo

400ccae

Adds conditional rspec test to test-all.sh (skips when rspec not installed). Fixes 'skip' to 'skip_test' for Graphite test. Signed-off-by: Brian Cosgrove <cosgroveb@gmail.com>

cosgroveb mentioned this pull request Mar 14, 2026

feat: add Ruby CLI support (rspec, rubocop) #292

Closed

navidemad mentioned this pull request Mar 19, 2026

feat(ruby): add Ruby on Rails support (rspec, rubocop, rake, bundle) #723

Closed

This was referenced Mar 19, 2026

feat(ruby): add Ruby on Rails support (rspec, rubocop, rake, bundle) #724

Merged

feat(rspec): add RSpec test runner with compact output (Rails/Ruby) #198

Closed

navidemad mentioned this pull request Mar 19, 2026

feat(ruby): add Ruby on Rails command support #643

Closed

8 tasks

cosgroveb closed this Mar 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/rspec test runner#534

Feat/rspec test runner#534
cosgroveb wants to merge 10 commits intortk-ai:developfrom
cosgroveb:feat/rspec-test-runner

cosgroveb commented Mar 12, 2026

Uh oh!

navidemad commented Mar 19, 2026

Uh oh!

cosgroveb commented Mar 19, 2026

Uh oh!

cosgroveb commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cosgroveb commented Mar 12, 2026

Summary

Test plan

Uh oh!

navidemad commented Mar 19, 2026

Uh oh!

cosgroveb commented Mar 19, 2026

Uh oh!

cosgroveb commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants