Skip to content

Security-fix: Remove further security issues in magnific.js #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoumaanAhamed merged 4 commits into from
Jan 2, 2026
Merged

Security-fix: Remove further security issues in magnific.js #2255

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35d98aa
chore: update magnific popup to v1.2.0
NoumaanAhamed Dec 31, 2025
cbce033
fix: improve close button markup handling and prependTo selector logic
NoumaanAhamed Jan 2, 2026
2fde69d
Merge branch 'fix/codeql-issues' into security-issue/magnific-update
NoumaanAhamed Jan 2, 2026
85cf074
fix: resolve merge conflicts in close button markup and prependTo logic
NoumaanAhamed Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions app/assets/js/vendors/magnific-popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,17 @@ var _mfpOn = function(name, f) {
},
_getCloseBtn = function(type) {
if(type !== _currPopupType || !mfp.currTemplate.closeBtn) {
mfp.currTemplate.closeBtn = $( mfp.st.closeMarkup.replace('%title%', mfp.st.tClose ) );

// 1. Create the raw markup (removing the placeholder string first)
var rawMarkup = mfp.st.closeMarkup.replace('%title%', '');

// 2. Parse it into a jQuery object
var $btn = $(rawMarkup);

// 3. Set the title attribute safely (jQuery handles the escaping)
$btn.attr('title', mfp.st.tClose);

mfp.currTemplate.closeBtn = $btn;
_currPopupType = type;
}
return mfp.currTemplate.closeBtn;
Expand Down Expand Up @@ -353,7 +363,14 @@ MagnificPopup.prototype = {
$('html').css(windowStyles);

// add everything to DOM
mfp.bgOverlay.add(mfp.wrap).prependTo( mfp.st.prependTo || $(document.body) );
var appendToEl = mfp.st.prependTo || $(document.body);

// FIX: If prependTo is a string, force it to be a selector
// by looking it up inside the body, rather than letting jQuery evaluate it.
if (typeof mfp.st.prependTo === 'string') {
appendToEl = $(document.body).find(mfp.st.prependTo);
}
mfp.bgOverlay.add(mfp.wrap).prependTo( appendToEl );

// Save last focused element
mfp._lastFocusedEl = document.activeElement;
Expand Down Expand Up @@ -506,7 +523,7 @@ MagnificPopup.prototype = {
_mfpTrigger('FirstMarkupParse', markup);

if(markup) {
mfp.currTemplate[type] = $(markup);
mfp.currTemplate[type] = $($.parseHTML(markup));
} else {
// if there is no markup found we just define that template is parsed
mfp.currTemplate[type] = true;
Expand Down
Loading