fix(update) : PHP 8.4 Compatibility

[NoumaanAhamed]

✅ PHP 8.4 Compatibility Summary & Fixes

1. Required Fix

File: app/importers/BPMediaAlbumimporter.php
Issue: die(true) is deprecated in PHP 8.4 (parameter must be a string or integer).
Fix: Replace deprecated function usage.

Change line 673 from:

die(true);

To:

exit;

---

2. Safe to Ignore (No Code Changes Needed)

File / Log	Issue	Reason
RTMediaUploadFile.php	read_exif_data() deprecated	Wrapped in function_exists() check → safe fallback
getid3.php	get_magic_quotes_runtime() deprecated	Inside version_compare() guard, does not execute on modern PHP
extension.cache.mysql.php	50+ mysql_* deprecated functions	Dead/unused file, never executed
General logs	safe_mode warnings	Harmless checks for removed INI setting
General logs	utf8_encode() / utf8_decode() deprecated	Still functional in PHP 8.4, only produces noise
node_modules/ warnings	Dependency build logs	Development-only files, not executed on production

---

Conclusion

Only a single change is required to remove an actual runtime deprecation.
Everything else is safely handled or unused and does not require modification.

[rtBot]

Unable to PHPCS or SVG scan one or more files due to error running PHPCS/SVG scanner:

• app/importers/BPMediaAlbumimporter.php

The error may be temporary. If the error persists, please contact a human (commit-ID: 2f98002).

[Copilot]

Pull request overview

This PR addresses PHP 8.4 compatibility by replacing the deprecated die(true) call with exit in the BuddyPress Media Album importer. In PHP 8.4, die() with a boolean parameter is deprecated and must receive a string or integer instead.

Key Changes:

• Replaced die(true) with exit to comply with PHP 8.4 deprecation requirements

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The logic for the nonce check appears to be inverted. The code currently deactivates the plugin when the nonce check fails (returns false). This means if the security check fails, the plugin gets deactivated, which is likely not the intended behavior.

The condition should be if ( check_ajax_referer(...) ) (without the ! negation) to deactivate the plugin only when the nonce is valid. Alternatively, if the intention is to prevent execution when the nonce is invalid, this should exit early on failure rather than deactivating the plugin.

Suggested change

	deactivate_plugins( 'bp-album/loader.php' );
	}
	wp_send_json( array( 'status' => false ) );
	}
	deactivate_plugins( 'bp-album/loader.php' );