Skip to content

Make media upload field mandatory & enhance aria-labels for accessibility #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SiddhiK13 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Make media upload field mandatory & enhance aria-labels for accessibility #2157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions templates/upload/uploader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,15 @@ function rtmedia_uploader_hidden_fields( $key, $value ) {
?>
<div class="rtm-file-input-container">
<p class="rtmedia-file-upload-p">
<input type="file" name="rtmedia_file_multiple[]" multiple="true" class="rtm-simple-file-input" id="rtmedia_simple_file_input" />
<input type="file" name="rtmedia_file_multiple[]" multiple="true" class="rtm-simple-file-input" id="rtmedia_simple_file_input" aria-label="Select media files to upload" multiple required/>
</p>
</div>
<?php
} else {
?>
<div class="rtm-file-input-container">
<p class="rtmedia-file-upload-p">
<input type="file" name="rtmedia_file" class="rtm-simple-file-input" id="rtmedia_simple_file_input" />
<input type="file" name="rtmedia_file" class="rtm-simple-file-input" id="rtmedia_simple_file_input" aria-label="Select a media file to upload" required/>
</p>
</div>
<?php
Expand All @@ -104,7 +104,7 @@ function rtmedia_uploader_hidden_fields( $key, $value ) {
<?php
} else {
?>
<p><input type="submit" name="rtmedia_simple_file_upload_submit" /></p>
<p><input type="submit" name="rtmedia_simple_file_upload_submit" aria-label="Upload selected media file" /></p>
</div>
</form>
<?php
Expand Down Expand Up @@ -152,7 +152,8 @@ function rtmedia_uploader_hidden_fields( $key, $value ) {
}
?>

<input type="submit" id='rtMedia-start-upload' name="rtmedia-upload" value="<?php echo esc_attr( RTMEDIA_UPLOAD_LABEL ); ?>" />
<input type="submit" id='rtMedia-start-upload' name="rtmedia-upload" value="<?php echo esc_attr( RTMEDIA_UPLOAD_LABEL ); ?>" aria-label="Start media upload" />


</div>
</div>
Expand Down