Adds Unit Test by vaishaliagola27 · Pull Request #49 · rtCamp/blank-theme

vaishaliagola27 · 2020-02-21T08:08:50Z

Add unit test cases.
Fixes Php Unit test case setup #33

Add phpunit GH action

rtBot

phpcs scanning turned up:

🚫 13 errors

⚠️ 4 warnings

hashes-api-scanning skipped

Posting will continue in further review(s)

rtBot · 2020-02-21T08:09:41Z

@@ -0,0 +1,20 @@
+<?php


⚠️ Warning: The "blank-theme" prefix is not a valid namespace/function/class/variable/constant prefix in PHP (WordPress.NamingConventions.PrefixAllGlobals.InvalidPrefixPassed).

rtBot · 2020-02-21T08:09:41Z

+	});
+	add_filter( 'pre_option_stylesheet', function() use ( $current_theme ) {
+		return $current_theme;
+	});


🚫 Error: Closing parenthesis of a multi-line function call must be on a line by itself (PEAR.Functions.FunctionCallSignature.CloseBracketLine).

rtBot · 2020-02-21T08:09:41Z

+	add_filter( 'pre_option_template', function() use ( $current_theme ) {
+		return $current_theme;
+	});
+	add_filter( 'pre_option_stylesheet', function() use ( $current_theme ) {


🚫 Error: Only one argument is allowed per line in a multi-line function call (PEAR.Functions.FunctionCallSignature.MultipleArguments).

rtBot · 2020-02-21T08:09:41Z

+	add_filter( 'pre_option_template', function() use ( $current_theme ) {
+		return $current_theme;
+	});
+	add_filter( 'pre_option_stylesheet', function() use ( $current_theme ) {


🚫 Error: Opening parenthesis of a multi-line function call must be the last content on the line (PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket).

rtBot · 2020-02-21T08:09:41Z

+
+	add_filter( 'pre_option_template', function() use ( $current_theme ) {
+		return $current_theme;
+	});


🚫 Error: Closing parenthesis of a multi-line function call must be on a line by itself (PEAR.Functions.FunctionCallSignature.CloseBracketLine).

rtBot · 2020-02-21T08:09:42Z

+
+	register_theme_directory( $theme_root );
+
+	add_filter( 'pre_option_template', function() use ( $current_theme ) {


🚫 Error: Only one argument is allowed per line in a multi-line function call (PEAR.Functions.FunctionCallSignature.MultipleArguments).

rtBot · 2020-02-21T08:09:42Z

+
+	register_theme_directory( $theme_root );
+
+	add_filter( 'pre_option_template', function() use ( $current_theme ) {


🚫 Error: Opening parenthesis of a multi-line function call must be the last content on the line (PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket).

rtBot · 2020-02-21T08:09:42Z

+
+	add_filter( 'theme_root', function() use ( $theme_root ) {
+		return $theme_root;
+	} );


🚫 Error: Closing parenthesis of a multi-line function call must be on a line by itself (PEAR.Functions.FunctionCallSignature.CloseBracketLine).

rtBot · 2020-02-21T08:09:42Z

+	$current_theme = basename( $theme_dir );
+	$theme_root = dirname( $theme_dir );
+
+	add_filter( 'theme_root', function() use ( $theme_root ) {


🚫 Error: Only one argument is allowed per line in a multi-line function call (PEAR.Functions.FunctionCallSignature.MultipleArguments).

rtBot · 2020-02-21T08:09:42Z

+	$current_theme = basename( $theme_dir );
+	$theme_root = dirname( $theme_dir );
+
+	add_filter( 'theme_root', function() use ( $theme_root ) {


🚫 Error: Opening parenthesis of a multi-line function call must be the last content on the line (PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket).

rtBot

Previous scan continued.

rtBot · 2020-02-21T08:09:45Z

+
+	$theme_dir = dirname( __DIR__ );
+	$current_theme = basename( $theme_dir );
+	$theme_root = dirname( $theme_dir );


⚠️ Warning: Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space (Generic.Formatting.MultipleStatementAlignment.NotSameWarning).

rtBot · 2020-02-21T08:09:45Z

+ */
+function _register_theme() {
+
+	$theme_dir = dirname( __DIR__ );


⚠️ Warning: Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space (Generic.Formatting.MultipleStatementAlignment.NotSameWarning).

rtBot · 2020-02-21T08:09:45Z

+/**
+ * Registers theme
+ */
+function _register_theme() {


🚫 Error: Functions declared in the global namespace by a theme/plugin should start with the theme/plugin prefix. Found: "_register_theme" (WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedFunctionFound).

rtBot · 2020-02-21T08:09:45Z

+}
+
+if ( ! file_exists( $_tests_dir . '/includes/functions.php' ) ) {
+	echo "Could not find $_tests_dir/includes/functions.php, have you run bin/install-wp-tests.sh ?" . PHP_EOL;


🚫 Error: All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '"Could not find $_tests_dir/includes/functions.php, have you run bin/install-wp-tests.sh ?"' (WordPress.Security.EscapeOutput.OutputNotEscaped).

rtBot · 2020-02-21T08:09:45Z

+$_tests_dir = getenv( 'WP_TESTS_DIR' );
+
+if ( ! $_tests_dir ) {
+	$_tests_dir = rtrim( sys_get_temp_dir(), '/\\' ) . '/wordpress-tests-lib';


🚫 Error: Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$_tests_dir" (WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound).

rtBot · 2020-02-21T08:09:46Z

+ * @package Blank_Theme
+ */
+
+$_tests_dir = getenv( 'WP_TESTS_DIR' );


🚫 Error: Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$_tests_dir" (WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound).

rtBot · 2020-02-21T08:09:46Z

@@ -0,0 +1,48 @@
+<?php


⚠️ Warning: The "blank-theme" prefix is not a valid namespace/function/class/variable/constant prefix in PHP (WordPress.NamingConventions.PrefixAllGlobals.InvalidPrefixPassed).

Update Readme with Contributing guideline and Add tests folder to skip_folders list

Unit test cases

rtBot

phpcs scanning turned up:

🚫 1 error

⚠️ 2 warnings

hashes-api-scanning skipped

rtBot · 2020-03-24T12:17:24Z

+	 * @codeCoverageIgnore
 	 */
 	public function enqueue_customizer_scripts() {
 		wp_enqueue_script(


🚫 Error: Version parameter is not explicitly set or has been set to an equivalent of "false" for wp_enqueue_script; This means that the WordPress core version will be used which is not recommended for plugin or theme development (WordPress.WP.EnqueuedResourceParameters.NoExplicitVersion).

rtBot · 2020-03-24T12:17:25Z

+		}
+
+		if ( ! empty( $wp_customize->get_setting( 'blogdescription' ) ) ) {
+			$wp_customize->get_setting( 'blogdescription' )->transport  = 'postMessage';


⚠️ Warning: Equals sign not aligned correctly; expected 1 space but found 2 spaces (Generic.Formatting.MultipleStatementAlignment.IncorrectWarning).

rtBot · 2020-03-24T12:17:25Z

-		$wp_customize->get_setting( 'blogdescription' )->transport  = 'postMessage';
-		$wp_customize->get_setting( 'header_textcolor' )->transport = 'postMessage';
+		if ( ! empty( $wp_customize->get_setting( 'blogname' ) ) ) {
+			$wp_customize->get_setting( 'blogname' )->transport         = 'postMessage';


⚠️ Warning: Equals sign not aligned correctly; expected 1 space but found 9 spaces (Generic.Formatting.MultipleStatementAlignment.IncorrectWarning).

rtBot

phpcs scanning turned up:

🚫 1 error

hashes-api-scanning skipped

rtBot · 2020-03-24T12:53:10Z

 			get_template_directory_uri() . '/assets/build/js/admin/customizer.js',
 			[ 'customize-preview' ],
-			false,
+			false, // phpcs:ignore WordPress.WP.EnqueuedResourceParameters.NoExplicitVersion


🚫 Error: Only one argument is allowed per line in a multi-line function call (PEAR.Functions.FunctionCallSignature.MultipleArguments).

sagarnasit

@deepaklalwani97 Added couple of feedback, everything else looks good.

sagarnasit · 2020-03-25T11:09:25Z

 - Sync complete `build` directory on server. 
 - Before code push to repository, make sure you lint your code using `npm run precommit` command.

+## Contributing


We slightly updated our contributor's workflow content, To align with that please update flow here. You can refer https://github.com/rtCamp/edit-flow-slack-integration

sagarnasit · 2020-03-25T11:31:19Z

+		$this->assertEquals( 10, has_filter( 'excerpt_more', array( $this->instance, 'add_read_more_link' ) ) );
+		$this->assertEquals( 10, has_filter( 'body_class', array( $this->instance, 'filter_body_classes' ) ) );
+		$this->assertEquals( 10, has_action( 'wp_head', array( $this->instance, 'add_pingback_link' ) ) );


are these duplicate test cases? does looping through $hooks cover this test cases?

sagarnasit · 2020-03-25T12:09:58Z

@deepaklalwani97 I see lines are not 100% covered in test cases. Please add files for which test cases are not needed in the unit test ignore.

Add doc description for test functions

…issues

…-test

…x/misc-issues

Sync dev-unit-test branch with master and fix unit test cases

kiranpotphode and others added 10 commits January 22, 2020 15:03

Setup Theme PHPUnit tests

70dae56

Add PHPUnit tests for classes

9a3d459

Write test cases for Classes and add code coverage annotations

3c938c3

Fix issues with theme setup

ff3f0a9

Update tests

1fd953a

Merge branch 'fix/bug-inc-classes' into feature/GH-33-dir-classes

09474a6

Add phpunit GH action

90748ea

Merge pull request #45 from rtCamp/setup-phpunit-action

76156dd

Add phpunit GH action

Move title-tag support to init action

62b0759

Delete unwanted files

2f78b2f

vaishaliagola27 requested a review from DevikVekariya February 21, 2020 08:08

rtBot suggested changes Feb 21, 2020

View reviewed changes

vaishaliagola27 added 2 commits February 21, 2020 13:40

Add tests folder to skip_folders list

8a5e332

Update readme with Contributing guideline

bbf8de8

DevikVekariya requested a review from sagarnasit February 21, 2020 11:54

vaishaliagola27 and others added 14 commits February 21, 2020 17:37

Merge pull request #50 from rtCamp/update-gh-action

9ae2387

Update Readme with Contributing guideline and Add tests folder to skip_folders list

Restructure test files and remove unwanted files.

e51e858

Ignore traits directory from test coverage

73a269d

Add Utility class and load in test environment

6a26437

Fix code coverage for widgets class

348580d

Add test cases for missing methods

55559de

Fix class-assets code coverage

00aa155

Fix class-blank-theme.php unit test code coverage

631ffb5

Add missing test cases for test-class-customizer.php

b039262

Fix test cases for infinite scroll class

4e2dfe2

Fix assets class test case coverage

5a24ed9

Fix error with customize_register method

d8b21a0

Fix customizer test cases and run phpcbf on test cases

95c654e

Add test cases for custom functions

821afca

deepaklalwani97 added 3 commits March 4, 2020 20:26

Remove unnecessary setup code

627ca06

Add code coverage ignore to register asset methods

12b3959

Merge pull request #47 from rtCamp/feature/GH-33-dir-classes

a366cac

Unit test cases

rtBot suggested changes Mar 24, 2020

View reviewed changes

Fix phpcs

98c5555

rtBot suggested changes Mar 24, 2020

View reviewed changes

Fix phpcs

d0fc4d7

deepaklalwani97 changed the title ~~[WIP] Adds Unit Test~~ Adds Unit Test Mar 24, 2020

sagarnasit reviewed Mar 25, 2020

View reviewed changes

deepaklalwani97 added 5 commits March 25, 2020 18:34

Exclude template-tags and autoloader from code coverage

0cbd0e4

Update contributors workflow

099a823

Remove duplicate test assertions

5596f14

Add ignore annotation for a custom function

3b1fbf2

Add doc description for test functions

92c99b0

sagarnasit approved these changes Mar 26, 2020

View reviewed changes

deepaklalwani97 added 8 commits March 26, 2020 18:31

Fix covers annotation

f771143

Merge pull request #55 from rtCamp/update-test-docs

dcd5bee

Add doc description for test functions

Fix undefined function warning

679412e

Merge branch 'master' of github.com:rtCamp/blank-theme into fix/misc-…

0d201eb

…issues

Fix unit test cases after syncing branch with master

448abbd

Merge branch 'develop' of github.com:rtCamp/blank-theme into dev-unit…

f54537b

…-test

Merge branch 'dev-unit-test' of github.com:rtCamp/blank-theme into fi…

995799a

…x/misc-issues

Merge pull request #57 from rtCamp/fix/misc-issues

cbf2c9b

Sync dev-unit-test branch with master and fix unit test cases


		register_theme_directory( $theme_root );

		add_filter( 'pre_option_template', function() use ( $current_theme ) {

Conversation

vaishaliagola27 commented Feb 21, 2020 • edited by deepaklalwani97 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rtBot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rtBot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rtBot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rtBot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagarnasit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagarnasit commented Mar 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vaishaliagola27 commented Feb 21, 2020 •

edited by deepaklalwani97

Loading