Cleanup master branch after rsw branch merge#909
Conversation
* hactypes.el (link-to-org-id): Fix quote in docstring.
* hibtypes.el (hywiki-get-existing-page-file):
(hywiki-word-from-reference): Declare functions.
* hpath.el (hywiki-get-existing-page-file):
(hywiki-get-referent):
(hywiki-org-to-heading-instance):
(org-element-property): Declare functions.
(hywiki-directory): Defvar.
(hpath:org-normalize-title):
(hpath:org-normalize-titles): Rephrase long docstrings to fit in 80 chars.
* hsys-org.el (org-uuid-regexp): Defvar.
(hsys-org-link-at-p): Remove unused var: label.
* hui.el (hywiki-mode): Defvar
(hywiki-get-buffer-page-name):
(hywiki-in-page-p):
(hywiki-org-format-heading):
(hywiki-org-get-heading-match-regexp): Declare functions.
* hypb.el (hypb:in-string-p): Remove unused var: close-match-string. Mark
close-regexp as unused.
* hywiki.el (hywiki-org-format-heading):
(org-fold-core-remove-optimisation):
(org-fold-core-update-optimisation):
(org-fold-show-entry): Declare functions.
(hywiki-add-org-id): Fix quote in docstring.
hactypes.el
Outdated
| mail-msg-id mail-file))))) | ||
|
|
||
| (defact link-to-org-id (id &optional title) | ||
| (defact link-to-org-id (id &optional _title) |
There was a problem hiding this comment.
"hui.el:L2077" uses this title argument, so please remove the above change.
There was a problem hiding this comment.
@matsl , see above. Make this one change and then good to go. No further approval needed.
There was a problem hiding this comment.
The change does not invalidate calling it. It just silences the warning since the title argument is not used.
So am I right to assume that we will soon add some implementation using title in this defact? Since when I think about it now an optional parameter that is not used would be a good candidate to delete. Unless that is, it is needed due to some "framework" using it so it has to be there. But that would not be the case here I think.
Anyway, I'll remove it and we have the warning as a reminder that we need to fix the implmentation so that it uses the argument.
What
hactypes.el (link-to-org-id): Fix quote in docstring.
hibtypes.el (hywiki-get-existing-page-file):
(hywiki-word-from-reference): Declare functions.
hpath.el (hywiki-get-existing-page-file):
(hywiki-get-referent):
(hywiki-org-to-heading-instance):
(org-element-property): Declare functions.
(hywiki-directory): Defvar.
(hpath:org-normalize-title):
(hpath:org-normalize-titles): Rephrase long docstrings to fit in 80 chars.
hsys-org.el (org-uuid-regexp): Defvar.
(hsys-org-link-at-p): Remove unused var: label.
hui.el (hywiki-mode): Defvar
(hywiki-get-buffer-page-name):
(hywiki-in-page-p):
(hywiki-org-format-heading):
(hywiki-org-get-heading-match-regexp): Declare functions.
hypb.el (hypb:in-string-p): Remove unused var: close-match-string. Mark
close-regexp as unused.
hywiki.el (hywiki-org-format-heading):
(org-fold-core-remove-optimisation):
(org-fold-core-update-optimisation):
(org-fold-show-entry): Declare functions.
(hywiki-add-org-id): Fix quote in docstring.
Why
Silences byte compile warning messages.
Note
There are a two unused variables warnings. This PR assume that these
are left overs but it could also mean the code was not committed in a
finished state.