Overhaul the gem directory structure, add Travis and Gitlab build support #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use sudo for install ops on Travis Missed a sudo One more sudo fix
Added ext/ and lib/ directories. There's now a lib/fb.rb which is the main entry point for the gem, and it loads `fb/fb_ext` for the C extension. Set up building with `rake-compiler`. Moved README to USAGE.txt and set up a README.md suitable for display online
Install deps with bundler Fix the compile target task name Try a setup without the debconf-set-selections Restart fb after install Attempt to fix sysdba password Need sudo to read the master PW Fixed the wrong place cat the FB PW Another try at fixing the sysdba PW Fix gsec setup Another attempt (you know this is getting squashed) Just build one Ruby target until we get gsec figured out Try exporting the password Explicitly handle Fb::Error when dropping user Exclude the user drop, for testing on Travis Can't drop then re-add user on the same connection Explicit commit; attempt to avoid transaction timeout Ensure that the DB closes even if the user drop fails Don't drop the DB manually
Add travis to the firebird group so it can validate FB file existence Ensure DBs dir exists and is chown'd, reload groups after travis assignment Fix group memebership per travis docs When a scalpel doesn't work, try a sledgehammer
Merged
Closed
Contributor
|
I have added them to my fork , I will add there Firebird 3 testing in travis/github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the gem structure to be more idiomatic:
test_helperfor test setup, replacingFbTestCasesThis also updates the tests a bit to work better in container isolation:
rubytestuser is dropped if it exists, then recreated as needed. This allows testing in both aged and pristine environments.Finally, this adds support for building on Travis and Gitlab CI on Ruby 1.9, 2.0, 2.1, 2.2, 2.3, and 2.4.
It currently builds against Firebird-2.5, but future improvements could include CI for FB-3.0.