Implement ItemTemplateSelector support on DragDropGridView.ItemsSource#6
Open
KarsaOrlong1981 wants to merge 4 commits intoroubachof:mainfrom
Open
Implement ItemTemplateSelector support on DragDropGridView.ItemsSource#6KarsaOrlong1981 wants to merge 4 commits intoroubachof:mainfrom
KarsaOrlong1981 wants to merge 4 commits intoroubachof:mainfrom
Conversation
The refactoring involved consolidating the property change handlers for ItemTemplate and ItemTemplateSelector into a single OnItemTemplateChanged(BindableObject, object, object) method. This was unnecessary to create a separate handler for ItemTemplateSelector, as the shared handler already handles both cases by reloading items and using GetTemplateForItem(object) to select the appropriate template (via selector if present, otherwise the direct template). This reduces code duplication and maintains the same functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue #4 :
DragDropGridView: DataTemplateSelector Support & Refactoring
• Added full support for ItemTemplateSelector
• Introduced a new BindableProperty and corresponding property for the DataTemplateSelector
• Enhanced handler detection for ScrollView and RefreshView to prevent Android.Runtime.JavaProxyThrowable
exceptions when custom handlers are used that do not derive from UntouchableRefreshViewHandler or UntouchableScrollViewHandler
Please double check:
I'm not sure about this "Dragging behind Items behavior":
dragtest.mp4
Usage:
xmlns:gridLayout="clr-namespace:Sharpnado.Maui.DragDropGridView;assembly=Sharpnado.Maui.DragDropGridView"