Regear fix for 1.21.8+

[kirushkinx]

1.21.8 error log

Summary by CodeRabbit

• Refactor
  • Streamlined inventory regear loop with a precomputed bound for minor performance and readability improvements.
  • Removed an unnecessary control statement in the regear logic to simplify flow without altering behavior.
  • No changes to user-facing functionality or configuration.

[coderabbitai]

Walkthrough

Refactors regearKit loop to use a precomputed maxIndex for iteration and removes a redundant continue statement within an assignment branch. No public APIs or signatures changed.

Changes

Cohort / File(s)	Summary
Regear loop refactor src/main/java/dev/noah/perplayerkit/KitManager.java	Replaced inline Math.min bound with precomputed maxIndex for the for-loop; removed a no-op continue after assigning kit[i]. No functional behavior changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop through loops, quick as a kite,
Tweaked the bounds to keep them tight.
Snipped a needless “continue” tail—
Cleaner trails, without derail.
Carrot in paw, I refactor with cheer,
Code hops smoother, crystal clear. 🥕

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

src/main/java/dev/noah/perplayerkit/KitManager.java (2)

303-305: Clone ItemStack before assignment to prevent kit mutation via shared references.

Assigning the same ItemStack instance from the stored kit into the player inventory means later in-inventory mutations (durability, meta edits, enchants) can mutate the saved kit in memory. Clone on write.

-                playerInventory[i] = kit[i];
+                playerInventory[i] = kit[i].clone();

---

307-308: Enforce inventory update on every regearKit call
RegearCommand.java:105 invokes KitManager.get().regearKit(player, slot) without a subsequent player.updateInventory(), causing potential visual desync. Add player.updateInventory() after this call—or centralize the call by adding player.updateInventory() in KitManager.regearKit immediately after player.getInventory().setContents(...).

🧹 Nitpick comments (2)

src/main/java/dev/noah/perplayerkit/KitManager.java (2)

286-289: LGTM: clearer bound with precomputed maxIndex.

Precomputing the loop bound improves readability and avoids repeated Math.min calls. Consider marking it final for intent.

-        int maxIndex = Math.min(kit.length, playerInventory.length);
+        final int maxIndex = Math.min(kit.length, playerInventory.length);

---

288-301: Avoid per-iteration String material checks; precompute Material set once.

Using toString() each iteration and a String Set is wasteful and brittle. Convert config strings to Material once, then compare enums in the loop.

Add import:

+import org.bukkit.Material;

Precompute before the loop:

Set<Material> wlMaterials = new HashSet<>();
for (String s : whitelist) {
    Material m = Material.matchMaterial(s);
    if (m != null) wlMaterials.add(m);
}

Then replace the checks inside the loop:

-            if (invertWhitelist) {
-                if (whitelist.contains(kit[i].getType().toString())) {
+            if (invertWhitelist) {
+                if (wlMaterials.contains(kit[i].getType())) {
                     continue;
                 }
-            } else {
-                if (!whitelist.contains(kit[i].getType().toString())) {
+            } else {
+                if (!wlMaterials.contains(kit[i].getType())) {
                     continue;
                 }
             }

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 21fabb8 and 3c2dadd.

📒 Files selected for processing (1)

• src/main/java/dev/noah/perplayerkit/KitManager.java (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/main/java/dev/noah/perplayerkit/KitManager.java (1)

src/main/java/dev/noah/perplayerkit/commands/RegearCommand.java (7)

• RegearInventoryHolder (191-200)
• Override (56-116)
• RegearCommand (27-201)
• EventHandler (147-188)
• Override (194-199)
• EventHandler (118-145)
• RegearCommand (38-46)