Skip to content

add timeout arguments elsewhere#1185

Merged
fujitatomoya merged 5 commits intorollingfrom
fujitatomoya/add-timeout-arguments-elsewhere
Mar 16, 2026
Merged

add timeout arguments elsewhere#1185
fujitatomoya merged 5 commits intorollingfrom
fujitatomoya/add-timeout-arguments-elsewhere

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

Description

Follow up of #1170, so that we can avoid the hang-up situation described in #1159

Fixes # (issue)

Is this user-facing behavior change?

No, the additional timeout falls back to the current behavior.

Did you use Generative AI?

Yes, Claude Sonnet 4.5

Additional Information

@fujitatomoya fujitatomoya requested a review from ahcorde February 5, 2026 23:55
@fujitatomoya fujitatomoya self-assigned this Feb 5, 2026
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

@araitaiga can you review this?

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

Pulls: #1185
Gist: https://gist.githubusercontent.com/fujitatomoya/2d2b948ddb17791c608d79be995d9fd8/raw/6ab0276f54acc2c7437ba4bea269b313011936f4/ros2.repos
BUILD args: --packages-above-and-dependencies ros2action ros2component ros2lifecycle ros2service ros2param
TEST args: --packages-above ros2action ros2component ros2lifecycle ros2service ros2param
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18138

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Comment thread ros2lifecycle/ros2lifecycle/verb/get.py
Comment thread ros2lifecycle/ros2lifecycle/api/__init__.py
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/add-timeout-arguments-elsewhere branch from 658cba8 to 116c3f4 Compare March 16, 2026 00:29
@fujitatomoya fujitatomoya requested review from Barry-Xu-2018 and araitaiga and removed request for araitaiga March 16, 2026 00:52
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

either @Barry-Xu-2018 or @ahcorde , can you review and merge this?

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Mar 16, 2026

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link
Copy Markdown
Contributor

@Barry-Xu-2018 Barry-Xu-2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor nit.
This suggestion is optional.

Comment thread ros2component/ros2component/api/__init__.py
@fujitatomoya fujitatomoya merged commit ef39b60 into rolling Mar 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants