Skip to content

Remove deprecated security properties and use new ones#217

Merged
fgallegosalido merged 3 commits intorollingfrom
feature/update-security-properties
Feb 10, 2026
Merged

Remove deprecated security properties and use new ones#217
fgallegosalido merged 3 commits intorollingfrom
feature/update-security-properties

Conversation

@fgallegosalido
Copy link
Copy Markdown
Collaborator

@fgallegosalido fgallegosalido commented Feb 6, 2026

Description

Some properties related to security artifacts have been deprecated for some time, and some of them removed in recent Connext versions. We replace them to use new ones

Is this user-facing behavior change?

Did you use Generative AI?

No

Additional Information

These new properties have been available since Connext 6.0.0, so backwards compatibility is not broken.

@fgallegosalido
Remove deprecated security properties and use new ones
9a32663 
Signed-off-by: Francisco Gallego Salido <fgallego@rti.com>
@fgallegosalido
Remove unnecessary code
2327ff1 
Signed-off-by: Francisco Gallego Salido <fgallego@rti.com>
@fgallegosalido
Remove unnecessary macros
8a16af6 
Signed-off-by: Francisco Gallego Salido <fgallego@rti.com>
@fgallegosalido
Copy link
Copy Markdown
Collaborator Author

fgallegosalido commented Feb 6, 2026

@ahcorde Can you take a look?

fujitatomoya
fujitatomoya approved these changes Feb 8, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Feb 8, 2026

Pulls: #217
Gist: https://gist.githubusercontent.com/fujitatomoya/996048e99787c34c7806b4dae607370e/raw/538d70eecc288968ec06577b6f778ce20e206a4d/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_connnextdds_common
TEST args: --packages-above rmw_connnextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18145

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Feb 9, 2026 •
edited
Loading

Pulls: #217
Gist: https://gist.githubusercontent.com/ahcorde/8140d728804b8bca82236864501ccb80/raw/538d70eecc288968ec06577b6f778ce20e206a4d/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_connextdds_common
TEST args: --packages-above rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18150

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fgallegosalido fgallegosalido merged commit 08457cb into rolling Feb 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@colmenero colmenero colmenero approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fgallegosalido @fujitatomoya @ahcorde @colmenero