address warning: statement with no effect.

[fujitatomoya]

Description

see https://ci.ros2.org/job/ci_linux-aarch64/21795/clang-tidy/folder.-1643903456/source.270fa858-97ec-4b07-9c86-ec11c84b9370/#478

--- stderr: rcutils                                                            
In file included from /root/ros2_ws/colcon_ws/src/ros2/rcutils/src/filesystem.c:42:
/root/ros2_ws/colcon_ws/src/ros2/rcutils/src/filesystem.c: In function ‘rcutils_dir_iter_next’:
/root/ros2_ws/colcon_ws/src/ros2/rcutils/src/filesystem.c:478:67: warning: statement with no effect [-Wunused-value]
  478 |   RCUTILS_CHECK_FOR_NULL_WITH_MSG(iter->state, "iter is invalid", false);
      |                                                                   ^~~~~
/root/ros2_ws/colcon_ws/src/ros2/rcutils/include/rcutils/error_handling.h:215:7: note: in definition of macro ‘RCUTILS_CHECK_FOR_NULL_WITH_MSG’
  215 |       error_statement; \
      |       ^~~~~~~~~~~~~~~
---

Fixes # (issue)

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

we need to backport this fix to all downstream branches.

[fujitatomoya]

@clalancette can i have a review on this?

[ahcorde]

Pulls: #559
Gist: https://gist.githubusercontent.com/ahcorde/a21b9634d5669a512d5f689437755903/raw/223885013a5366c8d5799c0c789069ab4eab0ae3/ros2.repos
BUILD args: --packages-above-and-dependencies rcutils
TEST args: --packages-above rcutils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19212

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[jmachowinski]

@Mergifyio backport lyrical

[mergify]

backport lyrical

✅ Backports have been created

Details

• #560 address warning: statement with no effect. (backport #559) has been created for branch lyrical

[fujitatomoya]

@Mergifyio backport kilted jazzy humble

[mergify]

backport kilted jazzy humble

✅ Backports have been created

Details

• #561 address warning: statement with no effect. (backport #559) has been created for branch kilted
• #562 address warning: statement with no effect. (backport #559) has been created for branch jazzy but encountered conflicts

Cherry-pick of e04f58b has failed:

On branch mergify/bp/jazzy/pr-559
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit e04f58b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/filesystem.c

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

• #563 address warning: statement with no effect. (backport #559) has been created for branch humble but encountered conflicts

Cherry-pick of e04f58b has failed:

On branch mergify/bp/humble/pr-559
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit e04f58b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/filesystem.c

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally