Skip to content

move __STDC_WANT_LIB_EXT1__ macro to CMakeLists.txt.#555

Open
fujitatomoya wants to merge 1 commit into
rollingfrom
fujitatomoya/issues/552
Open

move __STDC_WANT_LIB_EXT1__ macro to CMakeLists.txt.#555
fujitatomoya wants to merge 1 commit into
rollingfrom
fujitatomoya/issues/552

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented Apr 21, 2026

Description

Fixes #552

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

@fujitatomoya fujitatomoya requested a review from ahcorde April 21, 2026 06:21
@fujitatomoya fujitatomoya self-assigned this Apr 21, 2026
fujitatomoya
fujitatomoya commented Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think that we should backport this fix to the all downstream distros, expecting some conflicts for doing that since the base code is bit different.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Apr 21, 2026

Pulls: #555
Gist: https://gist.githubusercontent.com/fujitatomoya/4cd99017dd1da292a1937755c45e345a/raw/979e3ab2e6d7170adc910e6c791055de47ddd41e/ros2.repos
BUILD args: --packages-above-and-dependencies rcutils
TEST args: --packages-above rcutils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19031

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya mentioned this pull request Apr 21, 2026
Open
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Apr 22, 2026

i am almost sure that CI warnings are unrelated to this PR.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Apr 22, 2026

  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented May 12, 2026

@Mergifyio rebase

@mergify
Copy link
Copy Markdown

mergify Bot commented May 12, 2026

rebase

✅ Branch has been successfully rebased

@fujitatomoya
move __STDC_WANT_LIB_EXT1__ macro to CMakeLists.txt.
41d0de6 
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/issues/552 branch from dacf180 to 41d0de6 Compare May 12, 2026 01:24
@fujitatomoya fujitatomoya requested a review from jmachowinski May 12, 2026 01:24
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented May 12, 2026

Pulls: #555
Gist: https://gist.githubusercontent.com/fujitatomoya/3df79d04a3fdebbc650e88acc3a31321/raw/979e3ab2e6d7170adc910e6c791055de47ddd41e/ros2.repos
BUILD args: --packages-above-and-dependencies rctils
TEST args: --packages-above rctils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19223

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented May 12, 2026

@jmachowinski @ahcorde either of you can review this? thanks in advance.

@jmachowinski
Copy link
Copy Markdown

jmachowinski commented May 12, 2026 •
edited
Loading

Note, you introduced a heavy change in the behavior with this commit. Before the definition was only used if this header was included, now you will propagate it down to all libs using rcutils.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented May 12, 2026

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented May 13, 2026

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmachowinski jmachowinski jmachowinski approved these changes

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees

@fujitatomoya fujitatomoya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

__STDC_WANT_LIB_EXT1__ defined after standard library headers are included, causes build failure

2 participants

@fujitatomoya @jmachowinski