Add nodelet implementation. #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional nodelet layer to mirror the node implementation. This allows the Slam GMapping library to be run as a nodelet instead. This would allow you to, for example, run it under the same nodelet manager as the nodelet producing the /scan output for greater efficiency.
This was referenced Nov 2, 2016
wjwwood
approved these changes
Nov 3, 2016
Member
wjwwood
left a comment
wjwwood
left a comment
There was a problem hiding this comment.
other than a small nitpick, lgtm
gmapping/src/nodelet.cpp
Outdated
| class SlamGMappingNodelet : public nodelet::Nodelet | ||
| { | ||
| public: | ||
| SlamGMappingNodelet() {}; |
Member
There was a problem hiding this comment.
nitpick: no ; required here (also below)
Removed superfluous semicolons and mildly clarified info stream output.
Contributor
Author
|
Hi @wjwwood -- thanks for catching those. I've submitted a new commit that removes them. Please use GitHub's new-ish squash on merge feature, or I'd be happy to squash them myself and force-push if you'd prefer. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional nodelet layer to mirror the node implementation. This allows the Slam GMapping library to be run as a nodelet instead. This would allow you to, for example, run it under the same nodelet manager as the nodelet producing the /scan output for greater efficiency.
Note that this was done in conjunction with a forthcoming change to the turtlebot_navigation package (pull request: turtlebot/turtlebot_apps#158), which serves as an example of the two nodelets running together under the same nodelet manager. Initial testing showed a ~11% reduction in overall memory usage and ~20% CPU usage running the slam_gmapping nodelet and depthimage_to_laserscan nodelet together, as compared to running slam_gmapping in a separate node.