Skip to content

[dictgen] Also forward declare namespaces, typedefs, enums:#8661

Open
Axel-Naumann wants to merge 1 commit intoroot-project:masterfrom
Axel-Naumann:dict-fwd-decl-ns-td-enum
Open

[dictgen] Also forward declare namespaces, typedefs, enums:#8661
Axel-Naumann wants to merge 1 commit intoroot-project:masterfrom
Axel-Naumann:dict-fwd-decl-ns-td-enum

Conversation

@Axel-Naumann
Copy link
Copy Markdown
Member

@Axel-Naumann Axel-Naumann commented Jul 13, 2021

They were picked up as side effects of classes, but not forward declared as
and by themselves. This fixes namespaces and enums not being available / known at the ROOT prompt despite their dictionary being loaded:
https://root-forum.cern.ch/t/enum-in-namespace-not-available-after-loading-dictionary/45757

@Axel-Naumann Axel-Naumann self-assigned this Jul 13, 2021
@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

They were picked up as side effects of classes, but not forward declared as
and by themselves. This fixes namespaces and enums not being available / known
at the ROOT prompt despite their dictionary being loaded:
https://root-forum.cern.ch/t/enum-in-namespace-not-available-after-loading-dictionary/45757
@Axel-Naumann Axel-Naumann force-pushed the dict-fwd-decl-ns-td-enum branch from e50d397 to 22a84ec Compare July 13, 2021 14:07
@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

@phsft-bot
Copy link
Copy Markdown

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-07-13T15:46:23.191Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory

Failing tests:

@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented Jun 24, 2024

Restarted all tests to see how we are performing...

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 24, 2024

Test Results

    21 files      21 suites   3d 23h 30m 2s ⏱️
 3 793 tests  3 366 ✅ 0 💤   427 ❌
77 812 runs  76 556 ✅ 0 💤 1 256 ❌

For more details on these failures, see this check.

Results for commit 22a84ec.

♻️ This comment has been updated with latest results.

@dpiparo dpiparo closed this Dec 18, 2025
@dpiparo dpiparo reopened this Dec 18, 2025
@dpiparo dpiparo closed this Apr 10, 2026
@dpiparo dpiparo reopened this Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants