[r] Sanitize R package and repo names in TRInterface helpers#22181
Open
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Open
[r] Sanitize R package and repo names in TRInterface helpers#22181guitargeek wants to merge 1 commit intoroot-project:masterfrom
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Conversation
`TRInterface::IsInstalled`, `::Require`, and `::Install` built R source by concatenating the caller-provided package name into a string literal and passing it to the embedded R interpreter. Validate pkg against CRAN's package-name rule (starts with an ASCII letter, only letters, digits, and dots, does not end in a dot) before putting it into the R command, and emit an Error and return `kFALSE` on any other input. The `repos` argument of Install is validated to be a valid URL.
Test Results 22 files 22 suites 3d 10h 28m 33s ⏱️ For more details on these failures, see this check. Results for commit 4999865. ♻️ This comment has been updated with latest results. |
Member
|
Thanks a lot for taking the time to work on this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TRInterface::IsInstalled,::Require, and::Installbuilt R source by concatenating the caller-provided package name into a string literal and passing it to the embedded R interpreter.Validate pkg against CRAN's package-name rule (starts with an ASCII letter, only letters, digits, and dots, does not end in a dot) before putting it into the R command, and emit an Error and return
kFALSEon any other input.The
reposargument of Install is validated to be a valid URL.