[webgeom] provide virtual interfaces#21875
Open
linev wants to merge 3 commits intoroot-project:masterfrom
Open
[webgeom] provide virtual interfaces#21875linev wants to merge 3 commits intoroot-project:masterfrom
linev wants to merge 3 commits intoroot-project:masterfrom
Conversation
Contributor
|
@linev Thank you! |
Test Results 22 files 22 suites 3d 3h 16m 15s ⏱️ Results for commit aad4520. ♻️ This comment has been updated with latest results. |
silverweed
reviewed
Apr 10, 2026
silverweed
reviewed
Apr 10, 2026
bellenot
approved these changes
Apr 10, 2026
Member
bellenot
left a comment
bellenot
left a comment
There was a problem hiding this comment.
LGTM, once the comments from @silverweed have been addressed
Allows adjustment of RGeoItem in derived classes
Let decide to fully stream hierarchy at once in the beginning
Let extend method in derived classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide minimal virtual interface for
RGeomDescriptionandRGeomHierarchyclasses.Allows to extend functionality in EVE7.