[BP][626] [io] Improve checks when reading arrays with TBufferFile#21871
Merged
dpiparo merged 3 commits intoroot-project:v6-26-00-patchesfrom Apr 9, 2026
Merged
[BP][626] [io] Improve checks when reading arrays with TBufferFile#21871dpiparo merged 3 commits intoroot-project:v6-26-00-patchesfrom
dpiparo merged 3 commits intoroot-project:v6-26-00-patchesfrom
Conversation
thanks to @Sebasteuo (cherry picked from commit cc7e664)
Because, under certain circumstances, BufMax and fBufSize got out-of-sync Co-Authored-By: Philippe Canal <pcanal@fnal.gov> (cherry picked from commit 619d396)
i.e. in the TBufferFile::Read*Array* methods.
Previously, the collection length was checked to be positive
and that it was less than the total buffer size.
Those checks have been improved with a battery of 3 checks:
1. The collection's number of elements is checked to be positive
2. The collection length is checked to be positive
3. The collection length is checked to be less than the portion
of the buffer that remains to be read
The test roottest-root-io-prefetching-run had to be modified as well
because of what seems to be a corrupted input file.
thanks also to @Sebasteuo
(cherry picked from commit 6ab4902)
Test Results 3 files 3 suites 9h 42m 32s ⏱️ Results for commit 4bfa38f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BP of #21814