[builtins] download instead of bundle PCRE and bump from PCRE_8.43 to PCRE2_10.47#21857
Open
ferdymercury wants to merge 8 commits intoroot-project:masterfrom
Open
[builtins] download instead of bundle PCRE and bump from PCRE_8.43 to PCRE2_10.47#21857ferdymercury wants to merge 8 commits intoroot-project:masterfrom
ferdymercury wants to merge 8 commits intoroot-project:masterfrom
Conversation
… PCRE2_10.47 and lift CMAKE 3.5 policy version
ferdymercury
commented
Apr 9, 2026
| URL ${CMAKE_CURRENT_SOURCE_DIR}/pcre-${PCRE_VERSION}.tar.bz2 | ||
| URL_HASH SHA256=f1026a7f455b8ba726d6fff94d5f989e55ad55f7b4eb946938803ac2aa41743c | ||
| ExternalProject_Add(PCRE2 | ||
| URL https://github.com/PCRE2Project/pcre2/releases/download/pcre2-${PCRE2_VERSION}/pcre2-${PCRE2_VERSION}.tar.gz |
Collaborator
Author
There was a problem hiding this comment.
TO-DO change with LCG
Test Results 18 files 18 suites 2d 12h 38m 36s ⏱️ Results for commit b96a7bc. ♻️ This comment has been updated with latest results. |
bellenot
requested changes
Apr 9, 2026
Co-authored-by: Bertrand Bellenot <bellenot@users.noreply.github.com>
Member
|
Maybe @couet can check why it fails on MacOS with |
Member
|
It would be also useful to test the bultin on linux, using the build https://github.com/root-project/root/blob/master/.github/workflows/root-ci-config/buildconfig/alma10-clang_ninja.txt |
Member
the library is indeed called |
to check no conflicts with system library as suggested by dpiparo
ferdymercury
commented
Apr 10, 2026
thanks to dpiparo
Collaborator
Author
Thanks a lot! Mac failures seem now solved :) If you put the package in LCG I can amend the URL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and lift CMAKE 3.5 policy version