[llvm-project] Reland "Reland [Modules] Remove unnecessary check when…

[devajithvs]

… generating name lookup table in ASTWriter" (#139253)

Backport of llvm/llvm-project@1d0ee12

This will fix the macos failures in #21778

Direct link to the error: https://github.com/root-project/root/actions/runs/24071779572/job/70210751861 which looks like:

  Assertion failed: (ConstructorNameSet.empty() && "Failed to find all of the visible " "constructors by walking all the " "lexical members of the context."), function GenerateNameLookupTable, file ASTWriter.cpp, line 4662.
  Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
  0  libCling.so              0x0000000113736040 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 56
  1  libCling.so              0x0000000113733eb8 llvm::sys::RunSignalHandlers() + 64
  2  libCling.so              0x00000001137366a8 SignalHandler(int) + 344
  3  libsystem_platform.dylib 0x00000001928b56a4 _sigtramp + 56
  4  libsystem_pthread.dylib  0x000000019287b848 pthread_kill + 296
  5  libsystem_c.dylib        0x0000000192784a2c abort + 124
  6  libsystem_c.dylib        0x0000000192783c60 err + 0
  7  libCling.so              0x0000000113797dbc clang::ASTWriter::GenerateNameLookupTable(clang::ASTContext&, clang::DeclContext const*, llvm::SmallVectorImpl<char>&, llvm::SmallVectorImpl<char>&, llvm::SmallVectorImpl<char>&) (.cold.25) + 0
  8  libCling.so              0x000000011043cc30 clang::ASTWriter::GenerateNameLookupTable(clang::ASTContext&, clang::DeclContext const*, llvm::SmallVectorImpl<char>&, llvm::SmallVectorImpl<char>&, llvm::SmallVectorImpl<char>&) + 13940
  9  libCling.so              0x000000011043da58 clang::ASTWriter::WriteDeclContextVisibleBlock(clang::ASTContext&, clang::DeclContext*, unsigned long long&, unsigned long long&, unsigned long long&) + 1504
  10 libCling.so              0x000000011047209c clang::ASTDeclWriter::VisitDeclContext(clang::DeclContext*) + 200
....
....
0.	Program arguments: /Users/sftnight/ROOT-CI/build/bin/rootcling -rootbuild -v2 -f G__ROOTDataFrame.cxx -cxxmodule -s /Users/sftnight/ROOT-CI/build/lib/libROOTDataFrame.so -m Tree.pcm -m TreePlayer.pcm -m Hist.pcm -m ROOTVecOps.pcm -m Imt.pcm -m ROOTHist.pcm -excludePath /Users/sftnight/ROOT-CI/src -excludePath /Users/....

[github-actions]

Test Results

    22 files      22 suites   3d 3h 57m 32s ⏱️
 3 828 tests  3 827 ✅  1 💤 0 ❌
76 471 runs  76 453 ✅ 18 💤 0 ❌

Results for commit 8b25903.

[hahnjo]

Thanks!