Skip to content

HS3: PiecewiseInterpolationFactory: Allow for functions as vars#21626

Open
Phmonski wants to merge 1 commit intoroot-project:masterfrom
Phmonski:master
Open

HS3: PiecewiseInterpolationFactory: Allow for functions as vars#21626
Phmonski wants to merge 1 commit intoroot-project:masterfrom
Phmonski:master

Conversation

@Phmonski
Copy link
Contributor

Changes or fixes:

Changed casting for PiecewiseInterpolationFactory to allow for functions in dependencies.

Checklist:

  • tested changes locally

@Phmonski Phmonski requested a review from guitargeek as a code owner March 17, 2026 17:54
@github-actions
Copy link

Test Results

     6 files       6 suites   1d 4h 29m 0s ⏱️
 3 742 tests  3 738 ✅ 4 💤 0 ❌
21 727 runs  21 718 ✅ 9 💤 0 ❌

Results for commit 050a449.

@guitargeek
Copy link
Contributor

Hi! can you create a new PR from a development branch that is not called mater? Or CI actively rejects this case, because it can lead to subtle problems where the changes in the PR actually didn't get tested (thanks by the way, we learned about this problem because of your previous PRs!).

@guitargeek
Copy link
Contributor

(the changes look good to me, but it's important to also have a green CI run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants