[core] Fix improper name normalization in KeepNParams#21567
Open
silverweed wants to merge 1 commit intoroot-project:masterfrom
Open
[core] Fix improper name normalization in KeepNParams#21567silverweed wants to merge 1 commit intoroot-project:masterfrom
silverweed wants to merge 1 commit intoroot-project:masterfrom
Conversation
devajithvs
reviewed
Mar 11, 2026
devajithvs
reviewed
Mar 11, 2026
aa7739b to
0fd3044
Compare
Test Results 22 files 22 suites 3d 5h 47m 44s ⏱️ For more details on these failures, see this check. Results for commit f4e0d07. ♻️ This comment has been updated with latest results. |
0fd3044 to
c37967c
Compare
pcanal
reviewed
Mar 11, 2026
Contributor
Author
|
Test fails on mac with: which is concerning... |
The algorithm was not recording any default arguments into argsToKeep,
but it actually needs to keep them as long as they are followed by a
non-default argument.
This would cause issues such as this:
// std::less<int> is a default argument, but MyAlloc is not
using MyMap = std::map<int, int, std::less<int>, MyAlloc>;
TClass::GetClass("MyMap")->GetName() # prints "map<int,int,MyAlloc>" !
c37967c to
f4e0d07
Compare
devajithvs
reviewed
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The algorithm was not recording any default arguments into argsToKeep, but it actually needs to keep them as long as they are followed by a non-default argument.
This would cause issues such as this:
NOTE
I am not familiar with the Cling codebase so this fix might be missing something or be wrong for some other reason. The TClassEdit tests are passing, at least, but I kindly ask Cling experts to scrutinize this change thoroughly.
Checklist:
This PR fixes #