[RF] Optimizations to avoid taking logarithms of Gaussian constraints#21325
Draft
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Draft
[RF] Optimizations to avoid taking logarithms of Gaussian constraints#21325guitargeek wants to merge 1 commit intoroot-project:masterfrom
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 5h 43m 4s ⏱️ For more details on these failures, see this check. Results for commit 60813d8. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
log_optimizations
branch
2 times, most recently
from
ea59471 to
60813d8
Compare
guitargeek
force-pushed
the
log_optimizations
branch
from
60813d8 to
0b1aae1
Compare
Large likelihood fits (e.g. in CMS and ATLAS) often contain many Gaussian constraint terms. In the standard evaluation, these incur unnecessary overhead by computing the PDF value via `exp(...)` only to immediately take the logarithm in the constraint term. This commit introduces a log-space optimization that avoids the redundant exp -> log roundtrip. We need this optimization because it makes a difference for CMS, and they have also implemented something like this in the custom CMS Combine likelihood classes. If we want them to gradually move to "vanilla" RooFit, we need at least the same optimizations.
guitargeek
force-pushed
the
log_optimizations
branch
from
0b1aae1 to
2beea45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.