Remove stray line break when running root -q with input files
#21017
+11
−869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 13h 3m 1s ⏱️ For more details on these failures, see this check. Results for commit 2633d03. ♻️ This comment has been updated with latest results. |
Collaborator
|
Thanks! I guess this fixes a part of https://its.cern.ch/jira/browse/ROOT-8344 ? |
dpiparo
approved these changes
Jan 24, 2026
Member
dpiparo
left a comment
dpiparo
left a comment
There was a problem hiding this comment.
provided that the failures are understood.
guitargeek
force-pushed
the
rint_line_break
branch
4 times, most recently
from
14091da to
9e0dbe0
Compare
The problem with `grep -v` is that it returns an non-zero error status code if nothing was found, which is a prolem if the output has no lines other than the filtered one. The test would fail because the test driver thinks something went wrong because of the non-zero status code.
guitargeek
force-pushed
the
rint_line_break
branch
from
9e0dbe0 to
2633d03
Compare
ROOT first prints a newline before going over the inputs to separate printouts from the initial "root [0]" prompt. But if root is run with "-q", there is no prompt and we don't need the newline. Removing this spurious newline completely avoids all output when building ROOT, where the newline used to happen when running `hsimple.C`. This is commit is similar to 8e8b6bb, which removed another stray linebreak in the opposite case of running `root` with no input files.
guitargeek
force-pushed
the
rint_line_break
branch
from
2633d03 to
3534759
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROOT first prints a newline before going over the inputs to separate printouts from the initial "root [0]" prompt. But if root is run with "-q", there is no prompt and we don't need the newline.
Removing this spurious newline completely avoids all output when building ROOT, where the newline used to happen when running
hsimple.C.This is commit is similar to 8e8b6bb, which removed another stray linebreak in the opposite case of running
rootwith no input files.