Skip to content

Make RBatchLoader class more general and introduce class for tensor operators #20998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
martinfoell wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Make RBatchLoader class more general and introduce class for tensor operators #20998

martinfoell wants to merge 4 commits into from
+187 −267

Conversation

@martinfoell
Copy link
Contributor

@martinfoell martinfoell commented Jan 23, 2026

This Pull request:

  • Remove the training and validation distinction in the functions in RBatchLoader to make it more general
  • Add number of entries and drop remainder bool as input parameters to RBatchLoader to have a cleaner interaction between RBatchGenerator and RBatchLoader
  • Introduce class for tensor operators that simplifies RChunkLoader

@martinfoell martinfoell requested review from vepadulano and removed request for bellenot and lmoneta January 23, 2026 09:37
@martinfoell martinfoell self-assigned this Jan 23, 2026
vepadulano
vepadulano approved these changes Jan 23, 2026
View reviewed changes
Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, nice work! Let's first make sure the CI is green, then we can merge.

@martinfoell
Copy link
Contributor Author

martinfoell commented Jan 23, 2026

The code LGTM, nice work! Let's first make sure the CI is green, then we can merge.

Thank you!

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

Test Results

    22 files      22 suites   3d 16h 13m 51s ⏱️
 3 770 tests  3 770 ✅ 0 💤 0 ❌
74 986 runs  74 986 ✅ 0 💤 0 ❌

Results for commit 63751a3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guitargeek guitargeek guitargeek left review comments

@vepadulano vepadulano vepadulano approved these changes

Assignees

@martinfoell martinfoell

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martinfoell @guitargeek @vepadulano