[cppyy] Consider Python int and float for make_unique optimization
#20977
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
force-pushed
the
issue-19122
branch
from
8ce3445 to
116b21c
Compare
guitargeek
changed the title
int and float in make_unique optimizationint as possible for make_unique optimization
guitargeek
force-pushed
the
issue-19122
branch
from
116b21c to
489a32b
Compare
guitargeek
changed the title
int as possible for make_unique optimizationint and float for make_unique optimization
guitargeek
force-pushed
the
issue-19122
branch
from
489a32b to
25de749
Compare
The `std::make_unique` function is Pythonized to avoid unnecessary code generation by TClingCallFunc, which might also go wrong (as reported in GitHub issue root-project#19122). There is a fallback to calling the original `make_unique` for builtin types (introduced in [1]), but we don't need that if we know the builtin type can be readily used in the `unique_ptr` constructor, as is the case for `int` and `float`. Hence, this commit suggests to not use the fallback for `int` and `float`, which also closes root-project#19122 because no wrapper code has to be generated anymore. [1] wlav/cppyy@62a97c9
guitargeek
force-pushed
the
issue-19122
branch
from
25de749 to
7a5a2b9
Compare
Test Results 21 files 21 suites 3d 10h 17m 58s ⏱️ For more details on these failures, see this check. Results for commit 7a5a2b9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
std::make_uniquefunction is Pythonized to avoid unnecessary code generation by TClingCallFunc, which might also go wrong (as reported in GitHub issue #19122).There is a fallback to calling the original
make_uniquefor builtin types (introduced in [1]), but we don't need that if we know the builtin type can be readily used in theunique_ptrconstructor, as is the case forintandfloat.Hence, this commit suggests to not use the fallback for
intandfloat, which also closes #19122 because no wrapper code has to be generated anymore.[1] wlav/cppyy@62a97c9