Skip to content

[tmva][pymva] Fix signed integer comparisons #20955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vepadulano wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[tmva][pymva] Fix signed integer comparisons #20955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tmva/pymva/src/MethodPyKeras.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,7 +771,7 @@ std::vector<Double_t> MethodPyKeras::GetMvaValues(Long64_t firstEvt, Long64_t la

InitEvaluation(nEvents);

assert (fVals.size() == fNVars*nEvents);
assert (static_cast<Long64_t>(fVals.size()) == fNVars*nEvents);
for (UInt_t i=0; i<nEvents; i++) {
Data()->SetCurrentEvent(i);
const TMVA::Event *e = GetEvent();
Expand Down Expand Up @@ -847,8 +847,8 @@ std::vector<Float_t> MethodPyKeras::GetAllRegressionValues() {
InitEvaluation(nEvents);


assert (fVals.size() == fNVars*nEvents);
assert (fOutput.size() == fNOutputs*nEvents);
assert (static_cast<Long64_t>(fVals.size()) == fNVars*nEvents);
assert (static_cast<Long64_t>(fOutput.size()) == fNOutputs*nEvents);
for (UInt_t i=0; i<nEvents; i++) {
Data()->SetCurrentEvent(i);
const TMVA::Event *e = GetEvent();
Expand Down Expand Up @@ -914,8 +914,8 @@ std::vector<Float_t> MethodPyKeras::GetAllMulticlassValues() {
auto nEvents = Data()->GetNEvents();
InitEvaluation(nEvents);

assert (fVals.size() == fNVars*nEvents);
assert (fOutput.size() == fNOutputs*nEvents);
assert (static_cast<Long64_t>(fVals.size()) == fNVars*nEvents);
assert (static_cast<Long64_t>(fOutput.size()) == fNOutputs*nEvents);
for (UInt_t i=0; i<nEvents; i++) {
Data()->SetCurrentEvent(i);
const TMVA::Event *e = GetEvent();
Expand Down
10 changes: 5 additions & 5 deletions tmva/pymva/src/MethodPyTorch.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ std::vector<Double_t> MethodPyTorch::GetMvaValues(Long64_t firstEvt, Long64_t la

InitEvaluation(nEvents);

assert (fVals.size() == fNVars*nEvents);
assert (static_cast<Long64_t>(fVals.size()) == fNVars*nEvents);
for (UInt_t i=0; i<nEvents; i++) {
Data()->SetCurrentEvent(i);
const TMVA::Event *e = GetEvent();
Expand Down Expand Up @@ -650,8 +650,8 @@ std::vector<Float_t> MethodPyTorch::GetAllRegressionValues() {
InitEvaluation(nEvents);


assert (fVals.size() == fNVars*nEvents);
assert (fOutput.size() == fNOutputs*nEvents);
assert (static_cast<Long64_t>(fVals.size()) == fNVars*nEvents);
assert (static_cast<Long64_t>(fOutput.size()) == fNOutputs*nEvents);
for (UInt_t i=0; i<nEvents; i++) {
Data()->SetCurrentEvent(i);
const TMVA::Event *e = GetEvent();
Expand Down Expand Up @@ -721,8 +721,8 @@ std::vector<Float_t> MethodPyTorch::GetAllMulticlassValues() {
auto nEvents = Data()->GetNEvents();
InitEvaluation(nEvents);

assert (fVals.size() == fNVars*nEvents);
assert (fOutput.size() == fNOutputs*nEvents);
assert (static_cast<Long64_t>(fVals.size()) == fNVars*nEvents);
assert (static_cast<Long64_t>(fOutput.size()) == fNOutputs*nEvents);
for (UInt_t i=0; i<nEvents; i++) {
Data()->SetCurrentEvent(i);
const TMVA::Event *e = GetEvent();
Expand Down
Loading