Addressing issues #24 and #31 imposing an answer to #13#32
Open
arcturas1 wants to merge 3 commits intorooftopsparrow:SatChangesfrom
Open
Addressing issues #24 and #31 imposing an answer to #13#32arcturas1 wants to merge 3 commits intorooftopsparrow:SatChangesfrom
arcturas1 wants to merge 3 commits intorooftopsparrow:SatChangesfrom
Conversation
Got rid of un-needed main method in FourBit. Added a test. Un-comment…
Collaborator
Author
|
not sure if I did this quite right, but I'll request that this pull request be merged with the master if y'all approve of the changes. Otherwise, I can make a commit that reduces the scope to just deal with the javadoc compliance. |
Owner
|
I would really prefer that we split this MR up to just deal with Javadoc compliance, if you're able. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went a bit overboard and exceeded the scope of these issues. please carefully review the changes noted below and examine my source, as some things changed drastically.
#24 Ensure that Javadoc matches spec
Associated changes:
#31: Refactor Unlock Method
associated changes: