Add build stage to dev build instructions#244
Open
AntonOfTheWoods wants to merge 1 commit intorollup:masterfrom
Open
Add build stage to dev build instructions#244AntonOfTheWoods wants to merge 1 commit intorollup:masterfrom
AntonOfTheWoods wants to merge 1 commit intorollup:masterfrom
Conversation
ItsKDaniel
reviewed
Aug 5, 2022
ItsKDaniel
left a comment
ItsKDaniel
left a comment
There was a problem hiding this comment.
Instead, it would be best to execute npm run generate-graphs before executing dev. Can you confirm if that works rather than building the whole app?
ItsKDaniel
reviewed
Aug 5, 2022
| 2. `npm run update-guide` | ||
| 3. `npm run dev` | ||
| 4. Open up http://localhost:3000 | ||
| 3. `npm run build` |
There was a problem hiding this comment.
Refer #243 (comment)
Suggested change
| 3. `npm run build` | |
| 3. `npm run generate-graphs` |
Member
There was a problem hiding this comment.
Either this, or you change it to
npm installnpm run buildnpm run dev
As "build" also includes update-guide. The advantage is that is is easier for us to keep the build command stable and add additional steps there if they should prove necessary in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #243