Skip to content

Conversation

@sstok
Copy link
Member

@sstok sstok commented Jan 5, 2026

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? yes
Tickets
License MIT

Note: Support for Api-Platform 2.0 and 3.2 was dropped, it was already a challenge getting this thing to work as the internals of Api-Platform aren't fully documented, yet alone keeping compatibility for older versions.

I would accept a follow-up pull request that restores compatibility for older versions, but I'm not going to do it myself.

@sstok sstok force-pushed the feature/symfony-8 branch 2 times, most recently from 7bbeaab to 391cfc0 Compare January 5, 2026 12:46
@sstok
Copy link
Member Author

sstok commented Jan 5, 2026

This is going to take a lot more work than expected, matthiasnoback/symfony-dependency-injection-test:5.1 is not compatible with Symfony 8, but we can't use version 6.1 (which is compatible) as this requires a newer version of PHPUnit, which requires many changes to the codebase.

It worked locally as I wasn't using the Flex SYMFONY_REQUIRE environment option. But when enforcing all Symfony packages it fails.

@sstok sstok force-pushed the feature/symfony-8 branch 3 times, most recently from 5508ae6 to d82548c Compare January 6, 2026 15:39
@sstok
Copy link
Member Author

sstok commented Jan 6, 2026

The


Error:  Uncaught PHP Exception Rollerworks\Component\Search\ApiPlatform\Exception\InvalidConditionException: "[id][0]: This value is not valid." at SearchConditionListener.php line 211
Error:  Uncaught PHP Exception Rollerworks\Component\Search\ApiPlatform\Exception\InvalidConditionException: "[id][0]: This value is not valid." at SearchConditionListener.php line 211

Is irrelevant.

@sstok sstok force-pushed the feature/symfony-8 branch from d82548c to fb0be77 Compare January 6, 2026 19:06
Support for Api-Platform 2.0 and 3.2 was dropped
@sstok sstok force-pushed the feature/symfony-8 branch from fb0be77 to a5b6879 Compare January 6, 2026 19:09
@sstok sstok merged commit 2decf6f into rollerworks:main Jan 6, 2026
5 of 6 checks passed
@sstok sstok deleted the feature/symfony-8 branch January 6, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant