fix(emotion): handle trailing comma in styled(Component,)(styles)#32
Open
giggo1604 wants to merge 1 commit intorolldown:mainfrom
Open
fix(emotion): handle trailing comma in styled(Component,)(styles)#32giggo1604 wants to merge 1 commit intorolldown:mainfrom
giggo1604 wants to merge 1 commit intorolldown:mainfrom
Conversation
When styled() receives a single argument with a trailing comma (common in
.tsx files to disambiguate generics from JSX), the plugin injected ', {'
without checking for the existing comma, producing invalid JS with a
double comma.
Use checkTrailingCommaExistence()/maybeComma() before inserting the
{ target, label } object, consistent with all other injection sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When styled() receives a single argument with a trailing comma (common in .tsx files to disambiguate generics from JSX), the plugin injected ', {' without checking for the existing comma, producing invalid JS with a double comma.
Use checkTrailingCommaExistence()/maybeComma() before inserting the { target, label } object, consistent with all other injection sites.