Skip to content

[PWGUD] Please consider the following formatting changes to #11728 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolavick merged 1 commit into from
Jun 23, 2025
Merged

[PWGUD] Please consider the following formatting changes to #11728 #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions PWGUD/TableProducer/twoTracksEventTableProducer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,18 @@
#include "Framework/runDataProcessing.h"

// O2Physics headers
#include "PWGUD/Core/SGSelector.h"
#include "PWGUD/Core/UPCTauCentralBarrelHelperRL.h"
#include "PWGUD/DataModel/TwoTracksEventTables.h"
#include "PWGUD/DataModel/UDTables.h"

#include "Common/CCDB/EventSelectionParams.h"
#include "Common/Core/TrackSelection.h"
#include "Common/Core/TrackSelectionDefaults.h"
#include "Common/Core/trackUtilities.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/PIDResponse.h"
#include "Common/DataModel/TrackSelectionTables.h"
#include "PWGUD/Core/SGSelector.h"
#include "PWGUD/Core/UPCTauCentralBarrelHelperRL.h"
#include "PWGUD/DataModel/TwoTracksEventTables.h"
#include "PWGUD/DataModel/UDTables.h"

// ROOT
#include "Math/Vector4D.h"
Expand Down Expand Up @@ -148,13 +149,13 @@
{

// FTOA
if ((std::abs(coll.timeFT0A()) > maxFITtime) && coll.timeFT0A() > -998.)

Check failure on line 152 in PWGUD/TableProducer/twoTracksEventTableProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
histos.get<TH1>(HIST("Reco/hSelections"))->Fill(nSelection);
nSelection++;

// FTOC
if ((std::abs(coll.timeFT0C()) > maxFITtime) && coll.timeFT0C() > -998.)

Check failure on line 158 in PWGUD/TableProducer/twoTracksEventTableProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
histos.get<TH1>(HIST("Reco/hSelections"))->Fill(nSelection);
nSelection++;
Expand Down Expand Up @@ -392,7 +393,7 @@
} // Loop over tracks with selections

// Critical selection, without it the rest of the process function will fail
if (countGoodPVtracks != 2)

Check failure on line 396 in PWGUD/TableProducer/twoTracksEventTableProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return;
histos.get<TH1>(HIST("Reco/hSelections"))->Fill(nSelection);
nSelection++;
Expand Down Expand Up @@ -606,7 +607,7 @@
continue;
countMothers++;
// check the generated collision does not have more than 2 mothers
if (countMothers > 2) {

Check failure on line 610 in PWGUD/TableProducer/twoTracksEventTableProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if (verboseInfo)
printLargeMessage("Truth collision has more than 2 no mother particles. Breaking the particle loop.");
histos.get<TH1>(HIST("Truth/hTroubles"))->Fill(2);
Expand Down Expand Up @@ -690,7 +691,7 @@
continue;
countMothers++;
// check the generated collision does not have more than 2 mothers
if (countMothers > 2) {

Check failure on line 694 in PWGUD/TableProducer/twoTracksEventTableProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if (verboseInfo)
printLargeMessage("Truth collision has more than 2 no mother particles. Breaking the particle loop.");
histos.get<TH1>(HIST("Truth/hTroubles"))->Fill(12);
Expand Down Expand Up @@ -756,4 +757,3 @@
return WorkflowSpec{
adaptAnalysisTask<TwoTracksEventTableProducer>(cfgc)};
}

4 changes: 2 additions & 2 deletions PWGUD/Tasks/testMCstdTabsRL.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ struct TestMCstdTabsRL {

histos.get<TH2>(HIST("Events/Truth/hGenIDvsCountCollisions"))->Fill(collision.getGeneratorId(), 1);
histos.get<TH2>(HIST("Events/Truth/hGenIDvsNparticles"))->Fill(collision.getGeneratorId(), particles.size());
ROOT::Math::LorentzVector<ROOT::Math::PxPyPzE4D<double>> mother;

ROOT::Math::LorentzVector<ROOT::Math::PxPyPzE4D<double>> mother;
for (const auto& particle : particles) {
histos.get<TH2>(HIST("Events/Truth/hGenIDvsPDGcodesAll"))->Fill(collision.getGeneratorId(), particle.pdgCode());
// if (!particle.isPhysicalPrimary()) continue;
Expand Down
Loading