Skip to content

[PWGUD] Please consider the following formatting changes to #10781 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolavick merged 1 commit into from
Apr 7, 2025
Merged

[PWGUD] Please consider the following formatting changes to #10781 #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions PWGUD/Tasks/upcTauRl.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
tau_tree::TotalFT0AmplitudeA, tau_tree::TotalFT0AmplitudeC, tau_tree::TotalFV0AmplitudeA, tau_tree::EnergyCommonZNA, tau_tree::EnergyCommonZNC,
tau_tree::TimeFT0A, tau_tree::TimeFT0C, tau_tree::TimeFV0A, tau_tree::TimeZNA, tau_tree::TimeZNC,
tau_tree::TrkPx, tau_tree::TrkPy, tau_tree::TrkPz, tau_tree::TrkSign, tau_tree::TrkDCAxy, tau_tree::TrkDCAz, tau_tree::TrkTimeRes,
tau_tree::Trk1ITSclusterSizes, tau_tree::Trk2ITSclusterSizes,
tau_tree::Trk1ITSclusterSizes, tau_tree::Trk2ITSclusterSizes,
tau_tree::TrkTPCsignal, tau_tree::TrkTPCnSigmaEl, tau_tree::TrkTPCnSigmaMu, tau_tree::TrkTPCnSigmaPi, tau_tree::TrkTPCnSigmaKa, tau_tree::TrkTPCnSigmaPr, tau_tree::TrkTPCinnerParam,
tau_tree::TrkTOFsignal, tau_tree::TrkTOFnSigmaEl, tau_tree::TrkTOFnSigmaMu, tau_tree::TrkTOFnSigmaPi, tau_tree::TrkTOFnSigmaKa, tau_tree::TrkTOFnSigmaPr, tau_tree::TrkTOFexpMom);

Expand Down Expand Up @@ -775,10 +775,10 @@
bool reinstallRun2JpsiTrackSelection(T const& track)
{
// kInAcceptance copy
if (eta(track.px(), track.py(), track.pz()) < -0.8 || eta(track.px(), track.py(), track.pz()) > 0.8)

Check warning on line 778 in PWGUD/Tasks/upcTauRl.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
// kPrimaryTracks
if (std::abs(track.dcaZ()) > 2.0)

Check warning on line 781 in PWGUD/Tasks/upcTauRl.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
float maxDCA = 0.0105f + 0.0350f / std::pow(track.pt(), 1.1f);
if (std::abs(track.dcaXY()) > maxDCA)
Expand All @@ -787,18 +787,18 @@
// ITS
if (!track.hasITS())
return false; // ITS refit
if (track.itsChi2NCl() > 36.)

Check warning on line 790 in PWGUD/Tasks/upcTauRl.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
if (!isFulfillsITSHitRequirementsReinstatement(track.itsClusterMap()))
return false;
// TPC
if (!track.hasTPC())
return false; // TPC refit
if ((track.tpcNClsFindable() - track.tpcNClsFindableMinusFound()) < 70)

Check warning on line 797 in PWGUD/Tasks/upcTauRl.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false; // tpcNClsFound()
if ((static_cast<float>(track.tpcNClsCrossedRows()) / static_cast<float>(track.tpcNClsFindable())) < 0.8)

Check warning on line 799 in PWGUD/Tasks/upcTauRl.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
if (track.tpcChi2NCl() > 4.)

Check warning on line 801 in PWGUD/Tasks/upcTauRl.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
// TOF
if (!track.hasTOF())
Expand All @@ -821,11 +821,11 @@
(trk1.tpcNSigmaEl() * trk1.tpcNSigmaEl() + trk2.tpcNSigmaEl() * trk2.tpcNSigmaEl()))
return false; // definitely muon than electron
// event
if (collision.posZ() > 15.)

Check warning on line 824 in PWGUD/Tasks/upcTauRl.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
if (rapMother < -0.8 || rapMother > 0.8)

Check warning on line 826 in PWGUD/Tasks/upcTauRl.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
if (aco > 4 * o2::constants::math::PI / 5) // max opening angle 144 degrees (I hope, check)

Check warning on line 828 in PWGUD/Tasks/upcTauRl.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;

return true;
Expand All @@ -846,7 +846,7 @@
{

// FTOA
if ((std::abs(coll.timeFT0A()) > maxFITtime) && coll.timeFT0A() > -998.)

Check warning on line 849 in PWGUD/Tasks/upcTauRl.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;

// FTOC
Expand Down Expand Up @@ -2124,8 +2124,8 @@
float dcaxy[2] = {trk1.dcaXY(), trk2.dcaXY()};
float dcaz[2] = {trk1.dcaZ(), trk2.dcaZ()};
float trkTimeRes[2] = {trk1.trackTimeRes(), trk2.trackTimeRes()};
uint32_t itsClusterSizesTrk1 = trk1.itsClusterSizes();
uint32_t itsClusterSizesTrk2 = trk2.itsClusterSizes();
uint32_t itsClusterSizesTrk1 = trk1.itsClusterSizes();
uint32_t itsClusterSizesTrk2 = trk2.itsClusterSizes();
float tpcSignal[2] = {trk1.tpcSignal(), trk2.tpcSignal()};
float tpcEl[2] = {trk1.tpcNSigmaEl(), trk2.tpcNSigmaEl()};
float tpcMu[2] = {trk1.tpcNSigmaMu(), trk2.tpcNSigmaMu()};
Expand All @@ -2140,14 +2140,13 @@
float tofKa[2] = {trk1.tofNSigmaKa(), trk2.tofNSigmaKa()};
float tofPr[2] = {trk1.tofNSigmaPr(), trk2.tofNSigmaPr()};
float tofEP[2] = {trk1.tofExpMom(), trk2.tofExpMom()};
float ZNinfo[4] = {-999.,-999.,-999.,-999.};
if constexpr (requires { collision.udZdcsReduced(); }) {
ZNinfo[0] = collision.energyCommonZNA();
ZNinfo[1] = collision.energyCommonZNC();
ZNinfo[2] = collision.timeZNA();
ZNinfo[3] = collision.timeZNC();
}

float ZNinfo[4] = {-999., -999., -999., -999.};
if constexpr (requires { collision.udZdcsReduced(); }) {
ZNinfo[0] = collision.energyCommonZNA();
ZNinfo[1] = collision.energyCommonZNC();
ZNinfo[2] = collision.timeZNA();
ZNinfo[3] = collision.timeZNC();
}

tauTwoTracks(collision.runNumber(), collision.globalBC(), countTracksPerCollision, collision.numContrib(), countGoodNonPVtracks, collision.posX(), collision.posY(), collision.posZ(),
collision.flags(), collision.occupancyInTime(), collision.hadronicRate(), collision.trs(), collision.trofs(), collision.hmpr(),
Expand Down
Loading