Skip to content

[PWGUD] Please consider the following formatting changes to #10065 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolavick merged 1 commit into from
Feb 19, 2025
Merged

[PWGUD] Please consider the following formatting changes to #10065 #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PWGUD/Tasks/upcEventITSROFcounter.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check warning on line 1 in PWGUD/Tasks/upcEventITSROFcounter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Specify task name only when it cannot be derived from the struct name. Only append to the default name.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -51,10 +51,10 @@
Configurable<int> nTracksForUPCevent{"nTracksForUPCevent", 16, {"Maximum of tracks defining a UPC collision"}};

Configurable<bool> useTrueGap{"useTrueGap", true, {"Calculate gapSide for a given FV0/FT0/ZDC thresholds"}};
Configurable<float> cutMyGapSideFV0{"FV0", -1, "FV0A threshold for SG selector"};

Check warning on line 54 in PWGUD/Tasks/upcEventITSROFcounter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<float> cutMyGapSideFT0A{"FT0A", 150., "FT0A threshold for SG selector"};

Check warning on line 55 in PWGUD/Tasks/upcEventITSROFcounter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<float> cutMyGapSideFT0C{"FT0C", 50., "FT0C threshold for SG selector"};

Check warning on line 56 in PWGUD/Tasks/upcEventITSROFcounter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<float> cutMyGapSideZDC{"ZDC", 10., "ZDC threshold for SG selector"};

Check warning on line 57 in PWGUD/Tasks/upcEventITSROFcounter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
ConfigurableAxis axisRunNumbers{"axisRunNumbers", {1400, 544000.5, 545400.5}, "Range of run numbers"};

void init(InitContext&)
Expand Down Expand Up @@ -128,7 +128,7 @@
}
}
} // end loop over collisions
} // end loop over bcs
} // end loop over bcs

int arrAllColls[1000] = {0};
int arrUPCcolls[1000] = {0};
Expand Down Expand Up @@ -218,5 +218,5 @@
WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
{
return WorkflowSpec{
adaptAnalysisTask<UpcEventITSROFcounter>(cfgc, TaskName{"upc-event-itsrof-counter"})};

Check warning on line 221 in PWGUD/Tasks/upcEventITSROFcounter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Device names upc-event-itsrof-counter and upc-event-i-t-s-r-o-fcounter generated from the specified task name upc-event-itsrof-counter and from the struct name UpcEventITSROFcounter, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to UpcEventItsrofCounter and removing TaskName.
}
Loading