Default Plugin Versions to AssemblyVersion when not provided#618
Open
KillStr3aK wants to merge 17 commits intoroflmuffin:mainfrom
Open
Default Plugin Versions to AssemblyVersion when not provided#618KillStr3aK wants to merge 17 commits intoroflmuffin:mainfrom
KillStr3aK wants to merge 17 commits intoroflmuffin:mainfrom
Conversation
49cdae2 to
0b2d9a1
Compare
KillStr3aK
commented
Nov 9, 2024
| if (Plugin is BasePlugin basePlugin) | ||
| { | ||
| // if no override we look for assembly version | ||
| if (basePlugin._version == "<unknown>") |
Contributor
Author
There was a problem hiding this comment.
maybe basePlugin.ModuleVersion instead of the backing field?
roflmuffin
reviewed
Jan 28, 2025
|
|
||
| public abstract string ModuleName { get; } | ||
| public abstract string ModuleVersion { get; } | ||
| public virtual string ModuleVersion { get => _version; } |
Owner
There was a problem hiding this comment.
Have you tried loading a plugin compiled with this API against an older version of CS#? Does it complain about the virtual/abstract change when its being invoked or does it generate the same IL code?
Contributor
Author
There was a problem hiding this comment.
if I recall correctly I did not, but I'll check today
Owner
There was a problem hiding this comment.
I guess the other way around would also be good, so old plugin against new CS#.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#340
Output 1
Output 2